Bug 248812

Summary: mail/mmh: fix build with -fno-common
Product: Ports & Packages Reporter: satanist+freebsd
Component: Individual Port(s)Assignee: Kyle Evans <kevans>
Status: Closed FIXED    
Severity: Affects Only Me CC: kevans, ports-bugs
Priority: --- Keywords: buildisok
Version: LatestFlags: satanist+freebsd: maintainer-feedback+
kevans: merge-quarterly+
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 248756    
Attachments:
Description Flags
Fix build with -fno-common (clang 11 and gcc 10) satanist+freebsd: maintainer-approval+

Description satanist+freebsd 2020-08-21 16:45:30 UTC
Created attachment 217423 [details]
Fix build with -fno-common (clang 11 and gcc 10)

Since -current uses clang 11 -fno-common is default. This patch fixes the build error.
Comment 1 Automation User 2020-08-21 17:11:32 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/180657009
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-08-21 18:13:03 UTC
A commit references this bug:

Author: kevans
Date: Fri Aug 21 18:12:19 UTC 2020
New revision: 545616
URL: https://svnweb.freebsd.org/changeset/ports/545616

Log:
  mail/mmh: fix build with -fno-common

  mmh had just a minor build issue with -fno-common, fixed with a trivial
  patch to extern the variable in question.

  PR:		248812
  Approved by:	satanist+freebsd@bureaucracy.de (maintainer)
  MFH:		2020Q3 (build fix: -fno-common)

Changes:
  head/mail/mmh/files/patch-uip_mhbuild.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-08-21 18:21:05 UTC
A commit references this bug:

Author: kevans
Date: Fri Aug 21 18:20:14 UTC 2020
New revision: 545618
URL: https://svnweb.freebsd.org/changeset/ports/545618

Log:
  MFH: r545616

  mail/mmh: fix build with -fno-common

  mmh had just a minor build issue with -fno-common, fixed with a trivial
  patch to extern the variable in question.

  PR:		248812
  Approved by:	satanist+freebsd@bureaucracy.de (maintainer)

  Approved by:	ports-secteam (implicit: -fno-common build fix)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/mail/mmh/files/patch-uip_mhbuild.c