Bug 248831

Summary: ftp/tnftpd: update to 20200704
Product: Ports & Packages Reporter: Rudolf Čejka <cejkar>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Some People CC: fernape
Priority: --- Keywords: buildisok, needs-qa
Version: LatestFlags: fernape: merge-quarterly+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update cejkar: maintainer-approval+

Description Rudolf Čejka 2020-08-22 14:28:45 UTC 
Created attachment 217442 [details]
Update

Please apply attached patch and remove files/patch-configure.ac.

Also, I have got build error from pkg-fallout@FreeBSD.org on i386 13.0-CURRENT, but I could not reproduce it as I do not have i386 13.0-CURRENT. Please, do you know what to do?

...
--- tnftpd ---
/bin/sh ../libtool  --tag=CC    --mode=link cc  -O2 -pipe  -DSUPPORT_UTMPX -fstack-protector-strong -fno-strict-aliasing
+-fstack-protector-strong -o tnftpd cmds.o conf.o ftpd.o  ftpcmd.o popen.o logutmp.o  logwtmp.o
+../libnetbsd/libnetbsd.la  ../ls/libls.la -lpam -lcrypt
libtool: link: cc -O2 -pipe -DSUPPORT_UTMPX -fstack-protector-strong -fno-strict-aliasing -fstack-protector-strong -o
+tnftpd cmds.o conf.o ftpd.o ftpcmd.o popen.o logutmp.o logwtmp.o  ../libnetbsd/.libs/libnetbsd.a ../ls/.libs/libls.a
+-lpam -lcrypt
ld: error: duplicate symbol: __progname
>>> defined at ignore_init.c:83 (/usr/local/poudriere/jails/head-i386/usr/src/lib/csu/common/ignore_init.c:83)
>>>            /usr/lib/crt1.o:(__progname)
>>> defined at ftpd.c
>>>            ftpd.o:(.bss+0x8)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [tnftpd] Error code 1
Comment 1 Automation User 2020-08-22 14:39:07 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/180848773
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2020-08-23 07:55:55 UTC 
*** Bug 248832 has been marked as a duplicate of this bug. ***
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2020-08-24 16:16:32 UTC 
^Triage: [tags] in issue Titles are deprecated.
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: Please, ensure patches conform to proper patch format.

Thanks!
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2020-08-24 16:16:56 UTC 
(In reply to Rudolf Čejka from comment #0)
You probably need something like:

CFLAGS+=       -fcommon

Cheers
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-09-02 06:40:45 UTC 
A commit references this bug:

Author: fernape
Date: Wed Sep  2 06:40:08 UTC 2020
New revision: 547332
URL: https://svnweb.freebsd.org/changeset/ports/547332

Log:
  ftp/tnftpd: update to 20200704

  Includes fix for clang11 -fno-common issue
  While here, pet linters.

  PR:	248831
  Submitted by:	cejkar@fit.vutbr.cz (maintainer)
  MFH:	2020Q3 (build fix, fno-common)

Changes:
  head/ftp/tnftpd/Makefile
  head/ftp/tnftpd/distinfo
  head/ftp/tnftpd/files/patch-configure.ac
  head/ftp/tnftpd/files/patch-src-Makefile.am
  head/ftp/tnftpd/files/patch-src-ftpd.c
  head/ftp/tnftpd/files/patch-src-logutmp.c
  head/ftp/tnftpd/files/patch-src-logwtmp.c
  head/ftp/tnftpd/files/patch-tnftpd.h
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-09-02 06:45:48 UTC 
A commit references this bug:

Author: fernape
Date: Wed Sep  2 06:45:24 UTC 2020
New revision: 547333
URL: https://svnweb.freebsd.org/changeset/ports/547333

Log:
  MFH: r547332

  ftp/tnftpd: update to 20200704

  Includes fix for clang11 -fno-common issue
  While here, pet linters.

  PR:	248831
  Submitted by:	cejkar@fit.vutbr.cz (maintainer)

  Approved by:	ports-secteam (blanket, build fix -fno-common)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/ftp/tnftpd/Makefile
  branches/2020Q3/ftp/tnftpd/distinfo
  branches/2020Q3/ftp/tnftpd/files/patch-configure.ac
  branches/2020Q3/ftp/tnftpd/files/patch-src-Makefile.am
  branches/2020Q3/ftp/tnftpd/files/patch-src-ftpd.c
  branches/2020Q3/ftp/tnftpd/files/patch-src-logutmp.c
  branches/2020Q3/ftp/tnftpd/files/patch-src-logwtmp.c
  branches/2020Q3/ftp/tnftpd/files/patch-tnftpd.h
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2020-09-02 06:46:11 UTC 
Committed with minor changes.

Thanks!