Bug 248858
| Summary: | www/tt-rss: Installs incorrect rc.d script when PGSQL=OFF | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vadim Belman <vrurg> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | dereks, netchild | ||||
| Priority: | --- | Keywords: | needs-qa, regression | ||||
| Version: | Latest | Flags: | dereks:
maintainer-feedback+
koobs: merge-quarterly- |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Ok I think I see the issue. The PSQL_VAR_OFF is incorrect. Should be PGSQL_.. Must have had it correct locally but changed it between commits. Created attachment 217469 [details]
Fix commenting of ttrssd.in between mysql and pgsql
Fixing the typo in PSQL_VARS_OFF and flip/flopping between options will comment either or now.
@Reporter/Maintainer Is quarterly affected by this? It shouldn't no. It was from 248601. A commit references this bug: Author: netchild Date: Tue Sep 1 10:01:55 UTC 2020 New revision: 547256 URL: https://svnweb.freebsd.org/changeset/ports/547256 Log: Fix PGSQL=OFF case. Submitted by: maintainer PR: 248858 Changes: head/www/tt-rss/Makefile |
With the latest update tt-rss port installs a rc.d script in which sets two different CHECK_CMD variables. The first is checking for mysql status, the second – for postgresql. The corresponding lines in port's files/ttrssd.in template look like: %%MYSQL%%CHECK_CMD="%%LOCALBASE%%/bin/mysqladmin -u mysqld ping" %%MYSQL%%CHECK_MSG="${name}: mysqladmin command failed; mysql not ready?" # Waiting for pg_isready when 9.3 is the default %%PGSQL%%CHECK_CMD="%%LOCALBASE%%/etc/rc.d/postgresql status" %%PGSQL%%CHECK_MSG="${name}: postgresql status failed; postgresql not ready?" Now, even though the port is configured to use MySQL, PostgreSQL check overrides it breaking the daemon startup.