Bug 248913

Summary:

net/nbdkit: TLS is not enabled

Product:

Ports & Packages

Reporter:

Alan Somers <asomers>

Component:

Individual Port(s)

Assignee:

Alan Somers <asomers>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

diizzy, kevans

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Fix TLS by adding USES=pkgconfig	none

Description Alan Somers freebsd_committer

2020-08-25 20:37:01 UTC

Even when building with the GNUTLS option on, nbdkit does not detect the presence of it, and it doesn't get enabled in the binary.  Reported via email by 	Richard W.M. Jones <rjones@redhat.com> .

Comment 1 Alan Somers freebsd_committer

2020-08-25 20:40:33 UTC

Created attachment 217524 [details]
Fix TLS by adding USES=pkgconfig

Comment 2 Kyle Evans freebsd_committer

2020-08-25 21:08:22 UTC

LGTM:

Approved by: kevans (ports)

Comment 3 Daniel Engberg freebsd_committer

2020-08-25 21:57:11 UTC

Doesn't that make all BUILD_DEPENDS on pkgconf redundant?

Comment 4 Alan Somers freebsd_committer

2020-08-25 22:16:56 UTC

(In reply to daniel.engberg.lists from comment #3)
You're right.  And the XXX_BUILD_DEPENDS probably ought to say XXX_USE+= pkgconf instead.  I could add a GNUTLS_USE= line, but since so many of the options depend on pkgconf anyway, I may as well make it unconditional.  This way the port won't break in the future if a new option gets added that depends on pkgconf.

Comment 5 commit-hook freebsd_committer

2020-08-25 22:38:11 UTC

A commit references this bug:

Author: asomers
Date: Tue Aug 25 22:37:57 UTC 2020
New revision: 546235
URL: https://svnweb.freebsd.org/changeset/ports/546235

Log:
  net/nbdkit: fix the GNUTLS option

  The GNUTLS option requires pkgconf.  Since so many options do, this commit
  enables it unconditionally.

  PR:		248913
  Reported by:	Richard W.M. Jones <rjones@redhat.com>
  Approved by:	kevans (ports)
  Sponsored by:	Axcient

Changes:
  head/net/nbdkit/Makefile