Bug 248917

Summary:

databases/slony1v2: Add LICENSE information

Product:

Ports & Packages

Reporter:

dgilbert

Component:

Individual Port(s)

Assignee:

Dmitry Marakasov <amdmi3>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

diizzy, fernape

Priority:

---

Keywords:

buildisok, needs-qa

Version:

Latest

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

248756

Attachments:

Description	Flags
patch to add LICENCE	none

Description dgilbert 2020-08-25 22:08:07 UTC

Created attachment 217528 [details]
patch to add LICENCE

Related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248756 , this port needs the -fno-common fix.

Also, attached, adds the LICENCE to Makefile.

Comment 1 Daniel Engberg freebsd_committer

2020-08-25 22:31:08 UTC

Hi,

According to https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses.html it should be LICENSE=

You should also specify LICENSE_FILE= which in this case seems to be COPYRIGHT as far as I can tell.
https://git.postgresql.org/gitweb/?p=slony1-engine.git;a=blob;f=COPYRIGHT;h=df7538529c1e509e8aade82ee5f64b1a85c799fd;hb=HEAD

Please also be consistent with upper and lower case
https://svnweb.freebsd.org/ports/head/databases/postgresql12-server/Makefile?revision=544810&view=markup#l16
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses.html

Best regards,
Daniel

Comment 2 Automation User 2020-08-25 22:37:00 UTC

Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/181956041

Comment 3 Fernando Apesteguía freebsd_committer

2020-08-26 07:30:49 UTC

LICENSE=        PostgreSQL
LICENSE_FILE=   COPYRIGHT

https://wiki.postgresql.org/wiki/Slony

Comment 4 dgilbert 2020-09-16 04:19:09 UTC

OK.  The licence is cool.  I don't see the fix for the duplicate symbols problem yet.  I was chatting with someone on IRC and this was apparently a known problem.

Comment 5 Dmitry Marakasov freebsd_committer

2021-02-19 12:43:38 UTC

As far as I can see, -fno-common problems were already fixed in r559866, so just adding license for this PR along with some minor cleanup.

Comment 6 commit-hook freebsd_committer

2021-02-19 12:44:28 UTC

A commit references this bug:

Author: amdmi3
Date: Fri Feb 19 12:43:29 UTC 2021
New revision: 566058
URL: https://svnweb.freebsd.org/changeset/ports/566058

Log:
  - Add LICENSE [1]
  - While here, dont't install unneeded docs, remove needless .include and update WWW

  PR:		248917 [1]
  Submitted by:	dgilbert@eicat.ca (maintainer) [1]

Changes:
  head/databases/slony1v2/Makefile
  head/databases/slony1v2/pkg-descr