Summary: | x11/xmascot: Fix -fno-common error | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Yoshihiro Takahashi <nyan> | ||||||||||||
Component: | Individual Port(s) | Assignee: | Rene Ladan <rene> | ||||||||||||
Status: | Closed FIXED | ||||||||||||||
Severity: | Affects Many People | CC: | CQG00620, kevans, nyan, rene | ||||||||||||
Priority: | --- | Flags: | koobs:
merge-quarterly?
|
||||||||||||
Version: | Latest | ||||||||||||||
Hardware: | Any | ||||||||||||||
OS: | Any | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 248756 | ||||||||||||||
Attachments: |
|
Created attachment 217645 [details]
Update the port
I forgot to attach the file.
Can you submit an actual diff instead of a zip file? Created attachment 217683 [details]
diff
I attache the diff.
Could you submit an actual diff and not a compressed file, so that one can view it directly here without having to download the thing? Created attachment 217689 [details]
xmascot diff
I have updated again.
Sorry for inconvenience.
Created attachment 221722 [details]
poudriere testport log on 13.0-ALPHA1 with the patch
Hello,
I've tested the patch on 13.0-ALPHA1 and build/run is fine.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ffce9c1d6dfcfacb319eed3c02c2d2dc4f44bd46 commit ffce9c1d6dfcfacb319eed3c02c2d2dc4f44bd46 Author: Yoshihiro Takahashi <nyan@FreeBSD.org> AuthorDate: 2021-04-09 14:56:27 +0000 Commit: Rene Ladan <rene@FreeBSD.org> CommitDate: 2021-04-09 15:03:25 +0000 x11/xmascot: clean up port - fix build with -fno-common and un-expire - set LICENSE - fix parallel build - move to MASTER_SITE of submitter Add entry to LEGAL Submitter becomes maintainer PR: 249011 MFH: 2021Q2 LEGAL | 1 + x11/xmascot/Makefile | 42 ++++++++++++++++-------------- x11/xmascot/distinfo | 5 ++-- x11/xmascot/files/patch-config.tmpl (gone) | 10 ------- x11/xmascot/pkg-plist | 2 ++ 5 files changed, 29 insertions(+), 31 deletions(-) A commit in branch 2021Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e1fb9ce7111c24f22ba0c8622480fe9a6339f702 commit e1fb9ce7111c24f22ba0c8622480fe9a6339f702 Author: Yoshihiro Takahashi <nyan@FreeBSD.org> AuthorDate: 2021-04-09 14:56:27 +0000 Commit: Rene Ladan <rene@FreeBSD.org> CommitDate: 2021-04-09 15:09:16 +0000 x11/xmascot: clean up port - fix build with -fno-common and un-expire - set LICENSE - fix parallel build - move to MASTER_SITE of submitter Add entry to LEGAL Submitter becomes maintainer PR: 249011 MFH: 2021Q2 (cherry picked from commit ffce9c1d6dfcfacb319eed3c02c2d2dc4f44bd46) LEGAL | 1 + x11/xmascot/Makefile | 42 ++++++++++++++++-------------- x11/xmascot/distinfo | 5 ++-- x11/xmascot/files/patch-config.tmpl (gone) | 10 ------- x11/xmascot/pkg-plist | 2 ++ 5 files changed, 29 insertions(+), 31 deletions(-) Committed, thanks for the patch! |
Created attachment 217644 [details] Commercial use is prohibited I have fixed -fno-common error and changed the followings. - Add LEGAL because commercial use is prohibited. - Add LICENSE. - Fix -fno-common error and warnings. - Remove files/* patch that merged to distfile. - Use Github. - Install X11 resource file for UTF-8.