Bug 249018
| Summary: | emulators/wine-devel: add option to use emulators/dosbox or emulators/dosbox-staging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> | ||||
| Component: | Individual Port(s) | Assignee: | Gerald Pfeifer <gerald> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Some People | CC: | gerald, knyght, lwhsu, makc | ||||
| Priority: | --- | Flags: | gerald:
maintainer-feedback-
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Over to maintainer. Gerald, something wrong with patch? (In reply to VVD from comment #2) > Gerald, something wrong with patch? No, and sorry for the delay. I would prefer not to take this into the port, since it complicates the port and adds (yet) another thing I cannot actually test and not really maintain. Is this important for you? Do you have a particular use case/reason? (In reply to Gerald Pfeifer from comment #3) AFAIU, dosbox-staging is more active project: https://dosbox-staging.github.io/about/ Use SDL2 (I want remove old SDL 1.2 from my hosts). Other differences are here: https://github.com/dosbox-staging/dosbox-staging#summary-of-differences-compared-to-upstream The patch for wine doesn't fix any bug, it's an enhancement, therefore it should be submitted directly upstream. As for new DOSBOX option I leave it to maintainer discretion. (In reply to Max Brazhnikov from comment #5) > The patch for wine doesn't fix any bug, it's an enhancement, therefore > it should be submitted directly upstream. As for new DOSBOX option I leave > it to maintainer discretion. I agree, and will submit a variation to Wine upstream. Good point, Max!(In reply to VVD from comment #4) (In reply to VVD from comment #4) > AFAIU, dosbox-staging is more active project: > https://dosbox-staging.github.io/about/ Sorry for the delay on this, VVD. What do you think, could we simply *replace* the flavor of DOSBOX used? Or should we go for your original proposal with both options? As a (possibly relevant) note on this, the topic of SDL also came up in the context of bug#249869. (In reply to Gerald Pfeifer from comment #6) > I agree, and will submit a variation to Wine upstream. I have successfully done that in October: commit 689ff9c073785c0b462622c20dea8b30fe15d7d3 Author: Gerald Pfeifer <gerald@pfeifer.com> Date: Fri Oct 2 16:52:41 2020 +0300 winevdm: Abstract references to /dosbox. Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org> My feeling is to base on this and simply switch to the new flavor should there be interest (and someone to test/use). Since my question to that end hasn't received an answer I'm closing this PR (as Not Accepted for lack of a better option), but remain open to follow up. |
Created attachment 217657 [details] add option to use emulators/dosbox or emulators/dosbox-staging Testing on 12.1 amd64.