Bug 249048
| Summary: | x11-clocks/wmbinclock: fix recent "ld: error: duplicate symbol" breakage | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Harold Gutch <logix> | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | fernape, logix | ||||||
| Priority: | --- | Flags: | logix:
maintainer-feedback+
fernape: merge-quarterly+ |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 217702 [details]
additional improvements on top of submitter's patch
Add a couple of missing xorg modules and remove a noop REINPLACE_CMD.
(In reply to Fernando Apesteguía from comment #1) Looks good to me, thanks! A commit references this bug: Author: fernape Date: Wed Sep 2 10:05:07 UTC 2020 New revision: 547351 URL: https://svnweb.freebsd.org/changeset/ports/547351 Log: x11-clocks/wmbinclock: fix build in current Another case of -fno-common issue. While here, add a couple of missing xorg modules and remove a noop REINPLACE_CMD PR: 249048 Submitted by: logix@foobar.franken.de MFH: 2020Q3 (build fix, -fno-common) Changes: head/x11-clocks/wmbinclock/Makefile head/x11-clocks/wmbinclock/files/ head/x11-clocks/wmbinclock/files/patch-wmBinClock.c head/x11-clocks/wmbinclock/files/patch-xutils.c head/x11-clocks/wmbinclock/files/patch-xutils.h A commit references this bug: Author: fernape Date: Wed Sep 2 10:12:23 UTC 2020 New revision: 547352 URL: https://svnweb.freebsd.org/changeset/ports/547352 Log: MFH: r547351 x11-clocks/wmbinclock: fix build in current Another case of -fno-common issue. While here, add a couple of missing xorg modules and remove a noop REINPLACE_CMD PR: 249048 Submitted by: logix@foobar.franken.de Approved by: ports-secteam (blanket, build fix, -fno-common) Changes: _U branches/2020Q3/ branches/2020Q3/x11-clocks/wmbinclock/Makefile branches/2020Q3/x11-clocks/wmbinclock/files/ Committed and MFH'ed. Thanks! |
Created attachment 217687 [details] svnlite diff This fixes the recent build breakage that came with the clang update and the implicit "-fno-common". While here, also address the other warnings when building the port. Tested on -CURRENT as of Aug 27 and on 12.1-RELEASE, both with a current ports tree. Added files: x11-clocks/wmbinclock/files/patch-wmBinClock.c x11-clocks/wmbinclock/files/patch-xutils.c x11-clocks/wmbinclock/files/patch-xutils.h