Bug 249075
| Summary: | x11/xclip: fix xclip-pastefile | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tomohiro Hosaka <bokutin> | ||||
| Component: | Individual Port(s) | Assignee: | Nuno Teixeira <eduardo> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | chuck, dmgk, eduardo | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
(In reply to Tomohiro Hosaka from comment #0) Hi, Thanks for the patch. Looks like this was already fixed upstream [1] but the fix didn't make it into xclip-0.13. Would you mind updating PR to pull the patch from Github? Also, since this port is currently unmaintained, how do you feel about taking over the maintainership? [1] https://github.com/astrand/xclip/commit/db74a39e15f1a75bb1f828103ae7a8d2b4d8ccc3 Created attachment 218069 [details]
patch
Hi,
Thanks for your advice.
I followed the advice.
There is no problem changing the maintainer.
Thanks,
(In reply to Dmitri Goutnik from comment #1) Hello, I was about to adopt this port but I see your PR. What do you think about: - no need to add GH_PROJECT because it is equal to PORTNAME - using files/patches instead of REINPLACE_CMDs? . copy {WRKSRC}/xclip-copyfile to {WRKSRC}/xclip-copyfile.orig . copy {WRKSRC}/xclip-pastefile to {WRKSRC}/xclip-pastefile.orig . edit and make changes in {WRKSRC}/xclip-copyfile and {WRKSRC}/xclip-pastefile . run 'make makepatch' on port root to auto-generate patches . remove: post-patch and REINPLACE_CMD lines from Makefile - add license file: LICENSE_FILE= ${WRKSRC}/COPYING - install README file because it contains more info and examples: PORTDOCS= README OPTIONS_DEFINE= DOCS do-install-DOCS-on: @${MKDIR} ${STAGEDIR}${DOCSDIR} ${INSTALL_MAN} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR} Thanks, Nuno Teixeira Assign to current maintainer. Patch already committed in ports r568742. Coorect review r564845 |
tar is used in the xclip-pastefile. I get the following error: # xclip-pastefile tar: Error opening archive: Failed to open '/dev/sa0' It will be fixed below. --- xclip-pastefile.orig 2016-09-13 07:09:12 UTC +++ xclip-pastefile @@ -4,4 +4,4 @@ if [ "x$1" != "x" ]; then echo "Usage: $0" >&2 exit 1 fi -xclip -selection secondary -o | gunzip -c | tar xv +xclip -selection secondary -o | gunzip -c | tar xv -f - According to the Makefile style, is the below suitable? --- Makefile.orig 2020-09-03 18:40:55.121010000 +0900 +++ Makefile 2020-09-03 18:35:11.439860000 +0900 @@ -27,6 +27,7 @@ post-patch: ${REINPLACE_CMD} 's,mktemp,mktemp -t xclip,' ${WRKSRC}/xclip-copyfile + ${REINPLACE_CMD} 's,tar xv,tar xv -f -,' ${WRKSRC}/xclip-pastefile post-install: ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/xclip thanks.