Bug 249182
| Summary: | graphics/gdal: configure fails after r547690 if math/qhull5 is installed | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> |
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | stephen, sunpoet |
| Priority: | --- | Flags: | linimon:
maintainer-feedback?
(sunpoet) |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
John Hein
2020-09-07 21:20:07 UTC
(In reply to John Hein from comment #0) qhull5 is currently in LIB_DEPENDS for math/octave. Maybe math/qhull will work for octave, but I have not checked yet. (In reply to John Hein from comment #1) FYI, I built (& installed) math/octave using math/qhull instead of math/qhull5. 'make check' passed the hull tests. Index: math/octave/Makefile =================================================================== --- math/octave/Makefile (revision 547978) +++ math/octave/Makefile (working copy) @@ -28,7 +28,7 @@ libftgl.so:graphics/ftgl \ libhdf5.so:science/hdf5 \ libpcre.so:devel/pcre \ - libqhull.so.5:math/qhull5 \ + libqhull.so.7:math/qhull \ libqrupdate.so:math/qrupdate \ libumfpack.so:math/suitesparse \ libglpk.so:math/glpk \ (In reply to John Hein from comment #2) Or this slightly different patch to have math/octave depend on the qhull pkg instead of qhull5: Index: graphics/gdal/Makefile =================================================================== --- graphics/gdal/Makefile (revision 547978) +++ graphics/gdal/Makefile (working copy) @@ -15,13 +15,13 @@ LICENSE_FILE= ${WRKSRC}/LICENSE.TXT BUILD_DEPENDS= libgeotiff>=1.5.0:graphics/libgeotiff \ - proj>=6:graphics/proj + proj>=6:graphics/proj \ + qhull>0:math/qhull LIB_DEPENDS= libgeotiff.so:graphics/libgeotiff \ libgif.so:graphics/giflib \ libjson-c.so:devel/json-c \ libpng.so:graphics/png \ libproj.so:graphics/proj \ - libqhull.so:math/qhull \ libtiff.so:graphics/tiff OPTIONS_DEFINE= ARMADILLO CFITSIO CURL ECW EXPAT FREEXL GEOS GTA HDF5 JASPER \ (In reply to John Hein from comment #2) Sorry, ignore the patch from comment 2 - that was supposed to be an alternate diff for math/octave: Index: math/octave/Makefile =================================================================== --- math/octave/Makefile (revision 547978) +++ math/octave/Makefile (working copy) @@ -15,7 +15,8 @@ BUILD_DEPENDS= gnuplot:math/gnuplot \ ${LOCALBASE}/bin/gperf:devel/gperf \ gsed:textproc/gsed \ - ${LOCALBASE}/bin/makeinfo:print/texinfo + ${LOCALBASE}/bin/makeinfo:print/texinfo \ + qhull>0:math/qhull RUN_DEPENDS= gnuplot:math/gnuplot \ gsed:textproc/gsed \ ${LOCALBASE}/bin/makeinfo:print/texinfo @@ -28,7 +29,6 @@ libftgl.so:graphics/ftgl \ libhdf5.so:science/hdf5 \ libpcre.so:devel/pcre \ - libqhull.so.5:math/qhull5 \ libqrupdate.so:math/qrupdate \ libumfpack.so:math/suitesparse \ libglpk.so:math/glpk \ Committed. Thanks! A commit references this bug: Author: sunpoet Date: Tue Sep 8 17:50:54 UTC 2020 New revision: 548033 URL: https://svnweb.freebsd.org/changeset/ports/548033 Log: Use libqhull.so from math/qhull explicitly math/qhull provides libqhull.so.7 and math/qhull5 provides libqhull.so.5. PR: 249182 Reported by: John Hein <jcfyecrayz@liamekaens.com> Changes: head/graphics/gdal/Makefile (In reply to John Hein from comment #4) You could create another PR for math/octave. BTW, it does not seem correct to move qhull from LIB_DEPENDS (implies both BUILD and RUN) to BUILD_DEPENDS. A commit references this bug: Author: stephen Date: Tue Sep 8 18:07:41 UTC 2020 New revision: 548037 URL: https://svnweb.freebsd.org/changeset/ports/548037 Log: - Use math/qhull instead of math/qhull5. - Bump portrevision. PR: 249182 Submitted by: jcfyecrayz@liamekaens.com Changes: head/math/octave/Makefile I went ahead and committed the change in octave so that it uses qhull instead of qhull5. I had kept qhull5 because in the old days, octave didn't work with qhull. But that seems to have changed more recently. Also, I agree that the correct fix was to LIB_DEPENDS, not BUILD_DEPENDS. BTW, I didn't mean to close this PR. This might have been performed by the commit reference. (In reply to Stephen Montgomery-Smith from comment #11) It was closed by Sunpoet's commit. I agree LIB_DEPENDS is right. One just has to make changes on all consumers when the SO number changes on the shared lib - but that's not that hard. BUILD_DEPENDS _and_ RUN_DEPENDS would be required if we depend on the pkg instead of the shared lib. Thanks for fixing (both ports). |
