Bug 249273
| Summary: | pkgbase: missing colon in /usr/src/release/packages/runtime.ucl | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Martin <martin.jakob> |
| Component: | misc | Assignee: | Kyle Evans <kevans> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | allanjude, kevans, lwhsu, pkgbase |
| Priority: | --- | Keywords: | patch, pkgbase |
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
It is not required As explained here: https://github.com/vstakhov/libucl/#general-syntax-sugar key = value; section { key = value; } is equivalent to { "key": "value", "section": { "key": "value" } } However, it would likely be stylistically better to be consistent throughout the file. A commit references this bug: Author: kevans Date: Fri Sep 18 14:29:02 UTC 2020 New revision: 365883 URL: https://svnweb.freebsd.org/changeset/base/365883 Log: pkgbase: use consistent annotation for objectk eys Everywhere else we use objects ("scripts", generally) we do sepcify the optional colon. Be consistent and do the same for directories. PR: 249273 Submitted by: Martin <martin.jakob gmx com> MFC after: 1 week Changes: head/release/packages/runtime.ucl Thanks, i like consistency :) Can i close the ticket, or does this happen automatically? Whoops. =) A commit references this bug: Author: kevans Date: Sat Nov 14 20:44:34 UTC 2020 New revision: 367698 URL: https://svnweb.freebsd.org/changeset/base/367698 Log: MFC r365883: pkgbase: use consistent annotation for object keys Everywhere else we use objects ("scripts", generally) we do specify the optional colon. Be consistent and do the same for directories. PR: 249273 Changes: _U stable/12/ stable/12/release/packages/runtime.ucl |
There is a colon missing in the /usr/src/release/packages/runtime.ucl file, see below. --- /usr/src/release/packages/runtime.ucl 2019-06-02 09:09:55.106842000 +0200 +++ runtime.ucl 2020-09-12 09:21:57.013004000 +0200 @@ -30,7 +30,7 @@ version: "%VERSION%" } } -directories { +directories: { /dev = "y"; /tmp = "y"; }