Bug 249879

Summary: x11-toolkits/pango: Update to 1.46.2
Product: Ports & Packages Reporter: Olivier Duchateau <duchateau.olivier>
Component: Individual Port(s)Assignee: Port Management Team <portmgr>
Status: In Progress ---    
Severity: Affects Only Me CC: daniel.engberg.lists, greg, tcberner
Priority: --- Flags: tcberner: maintainer-feedback+
tcberner: exp-run?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to update x11-toolkits/pango
none
v1
none
Patch for pango - v1.48.0 none

Description Olivier Duchateau 2020-09-25 11:40:55 UTC
Created attachment 218276 [details]
Patch to update x11-toolkits/pango

- Update to 1.46.2
- Adjust dependencies
- Remove X11 option
- Remove patches
Comment 1 Tobias C. Berner freebsd_committer 2020-09-26 11:34:14 UTC
Moin moin 

Thank you for the patch.


mfg Tobias
Comment 2 Tobias C. Berner freebsd_committer 2020-09-26 11:44:21 UTC
Moin moin 

What was the reasoning behind dropping the X11 option?


mfg Tobias
Comment 3 Tobias C. Berner freebsd_committer 2020-09-26 13:57:03 UTC
Created attachment 218327 [details]
v1

Moin moin 

Based on your patch here's an updated version which keeps the X11 option around.


mfg Tobias
Comment 4 Tobias C. Berner freebsd_committer 2020-09-26 13:57:49 UTC
desktop@ would like to ask for an exp-run of this patch (v1), which can also be found here:
https://people.freebsd.org/~tcberner/patches/pango-1.46.2.v1.diff


mfg Tobias
Comment 5 Olivier Duchateau 2020-09-26 17:40:01 UTC
(In reply to Tobias C. Berner from comment #2)

Because when I submitted an update of Gtk3 bug #249288, comment #3 I remove support of X11. Wayland support for the Xfce desktop is not planned for the next stable major release.
Comment 6 Tobias C. Berner freebsd_committer 2020-09-26 18:02:52 UTC
I think it's not really a question of X11 vs Wayland, more of X11 vs NOX11 here.
Comment 8 Greg V 2020-10-16 12:47:51 UTC
Now 1.47.0 is out (and is required by gtk4 3.99.2)… not much change between these, just bump the version.

> eiskaltdcpp-gtk-2.2.10_20.log
> fatal error: 'hb.h' file not found

hmmm it's getting cflags for pango transitively from something, and that something doesn't include -I/usr/local/include/harfbuzz

> Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)

oh well it's even getting that something from CMake's magic finders, maybe USES+=pkgconfig is a good idea?

> codelite-12.0_4.log
> pcsxr-1.9.95.20180604_3.log

same thing in these but pkgconf is used >_<

Maybe just CFLAGS+=-I${LOCALBASE}/include/harfbuzz these as a hot fix..

> gtkhtml3-3.32.1_5.log
> error: implicit declaration of function 'pango_find_base_dir' is invalid in C99

-DPANGO_DISABLE_DEPRECATED must be removed in this port.

> pangox-compat-0.0.2_2.log
> pangox.c:282:15: error: no member named 'find_shaper' in 'struct _PangoFontClass'

Arch Linux simply commented out that line:
https://aur.archlinux.org/cgit/aur.git/tree/0002-disable-shaper.patch?h=pangox-compat

> py27-gtk2-2.24.0_5.log

same here but the fix has been merged:
https://gitlab.gnome.org/Archive/pygtk/-/merge_requests/1

so it should be updated to the latest git master https://gitlab.gnome.org/Archive/pygtk/-/commits/master/
Comment 9 Olivier Duchateau 2020-10-16 15:19:23 UTC
(In reply to Greg V from comment #8)

1.47.0 is development version?

GNOME project uses this versioning sheme:

- odd number is devel release
- even number is stable release
Comment 10 Greg V 2020-10-16 17:36:22 UTC
Oh actually—

> py27-gtk2-2.24.0_5.log

just got killed (yay!) https://svnweb.freebsd.org/ports?view=revision&revision=552492

(In reply to Olivier Duchateau from comment #9)

I'm not sure if pango follows the same scheme, maybe.
Comment 11 daniel.engberg.lists 2020-11-23 18:51:21 UTC
Created attachment 219910 [details]
Patch for pango - v1.48.0

Update to newest release, based on tcberner's patch.
Comment 12 daniel.engberg.lists 2020-11-23 19:13:07 UTC
* codelite --> Probably similar story as eiskaltdcpp (outdated and newer versions fixes issues)

* eiskaltdcpp --> Bump to latest commit and hope for the best (?)
https://github.com/eiskaltdcpp/eiskaltdcpp/releases/tag/v2.2.10
There are also build fixes for deps such as Pango
https://github.com/eiskaltdcpp/eiskaltdcpp/commit/8b22479aef21fb2b764051f0499ae5fba397d31f

* pcsxr --> Drop? The interesting parts are ported to libretro / retroarch
https://github.com/iCatButler/pcsxr/pull/21
https://github.com/libretro/pcsx1-libretro

* gtkhtml3 --> Deprecate? Dead upstream
https://gitlab.gnome.org/Archive/gtkhtml

* pangox-compat --> Deprecate? Dead upstream
https://gitlab.gnome.org/Archive/pangox-compat
Arch Linux seems to have a working version
https://aur.archlinux.org/packages/pangox-compat/
Comment 13 Tobias C. Berner freebsd_committer 2020-11-23 19:14:51 UTC
(In reply to daniel.engberg.lists from comment #12)
* pangox-compat is uised by a handfull of ports, is it really needed?