Bug 249895
| Summary: | devel/nlohmann-json: Request to install include/nlohmann/json_fwd.hpp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mateusz Piotrowski <0mp> | ||||
| Component: | Individual Port(s) | Assignee: | Mateusz Piotrowski <0mp> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | yuri | ||||
| Priority: | --- | Flags: | yuri:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Mateusz Piotrowski
2020-09-25 20:51:19 UTC
Yes, Please go ahead and alter devel/nlohmann-json to add this file. Thanks, Yuri A commit references this bug: Author: 0mp Date: Fri Sep 25 21:18:30 UTC 2020 New revision: 550083 URL: https://svnweb.freebsd.org/changeset/ports/550083 Log: devel/nlohmann-json: Install include/nlohmann/json_fwd.hpp This header file is required by future versions of sysutils/nix. In order to get that header installed, the JSON_MultipleHeaders option had to be enable. This option results in the build system installing a lot of other header files as well. As there is no need to ship those other headers at the moment, let's delete them in post-install. PR: 249895 Approved by: yuri@ (maintainer) Changes: head/devel/nlohmann-json/Makefile Done! Thanks! Wait, it turns out that that's not all. It looks like I need some other headers as well, which are currently deleted in post-install. I wonder if we should just install all the headers at this point. What do you think? (In reply to Mateusz Piotrowski from comment #4) What are these headers? Created attachment 218298 [details] Install all headers (In reply to Yuri Victorovich from comment #5) Hmm, it looks like if you specify JSON_MultipleHeaders then you just need all the headers anyway, because json.hpp one is now depending on them. As a result, I think that the last commit broke the port. Here's the patch which installs all the headers. (In reply to Mateusz Piotrowski from comment #6) Ah, yes, please add them too. Yuri A commit references this bug: Author: 0mp Date: Fri Sep 25 21:44:47 UTC 2020 New revision: 550086 URL: https://svnweb.freebsd.org/changeset/ports/550086 Log: devel/nlohmann-json: Install all the headers It turns out that it is necessary to ship all the headers if the JSON_MultipleHeaders option was used for building. Otherwise, even the most popular header, json.hpp, no longer works correctly. PR: 249895 Approved by: yuri@ (maintainer) Changes: head/devel/nlohmann-json/Makefile head/devel/nlohmann-json/pkg-plist Thanks again! |