Bug 249964
| Summary: | sysutils/lcdproc fix build with -fno-common | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Olivier Cochard <olivier> | ||||
| Component: | Individual Port(s) | Assignee: | Olivier Cochard <olivier> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | daniel, fernape | ||||
| Priority: | --- | Flags: | daniel:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 248756 | ||||||
| Attachments: |
|
||||||
^Triage: Reporter is committer, assign accordingly. Q/A: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. Thanks! (In reply to Fernando Apesteguía from comment #1) I didn't update all the existing patches (that was showing this warning message), I will let the maintainer made his choice about render all of them 'portlint' happy or not :-) Sorry, I've been busy lately. Quite strange that this problem started occuring. It worked fine without changes for over a year. However, has this problem been reported to lcdproc on GitHub? Is it specific to FreeBSD only perhaps? There are commits as recent as July 21st this year but the latest release is in 2017, so possible I could release it using the commits until the maintainer decides to do an official release. I've inquired him on it months ago but never got a real response as to when. (In reply to Daniel Shafer from comment #3) Hi Daniel, Both llvm and gcc changed the default for -fcommon and hence the error. Many ports have been affected by this. Olivier, would you commit this? A commit references this bug: Author: olivier Date: Mon Jan 4 15:55:10 UTC 2021 New revision: 560304 URL: https://svnweb.freebsd.org/changeset/ports/560304 Log: Fix build with -fno-common PR: 249964 Changes: head/sysutils/lcdproc/files/patch-clients__lcdproc__iface.c head/sysutils/lcdproc/files/patch-clients__lcdproc__iface.h Oops, forgot about this. |
Created attachment 218389 [details] patch to fix build Patch to fix this error on head: [00:01:03] ld: error: duplicate symbol: iface [00:01:03] >>> defined at main.c [00:01:03] >>> main.o:(iface) [00:01:03] >>> defined at iface.c [00:01:03] >>> iface.o:(.bss+0x0) [00:01:03] cc: error: linker command failed with exit code 1 (use -v to see invocation) [00:01:03] *** [lcdproc] Error code 1