Bug 250191

Summary: textproc/libcrm114: fix build with -fno-common and deprecate port
Product: Ports & Packages Reporter: Martin Schütte <info>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Some People CC: fernape
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fix -fno-common build of libcrm114 and deprecate info: maintainer-approval+

Description Martin Schütte 2020-10-07 22:27:50 UTC
Created attachment 218603 [details]
fix -fno-common build of libcrm114 and deprecate

This patch fixes the current build errors due to the -fno-common compile option.

I also suggest to mark the port as deprecated, because its upstream is abandoned since 2010 and I am not aware of any users.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-10-08 06:34:08 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-10-08 11:53:06 UTC
A commit references this bug:

Author: fernape
Date: Thu Oct  8 11:52:09 UTC 2020
New revision: 551701
URL: https://svnweb.freebsd.org/changeset/ports/551701

Log:
  textproc/libcrm114: fix build with -fno-common and deprecate port

  Upstream has been abandoned since 2010 and there are no consumers in the ports
  collection.

  Maintainer is not aware of any users either.

  PR:	250191
  Submitted by:	info@mschuette.name (maintainer)

Changes:
  head/textproc/libcrm114/Makefile
  head/textproc/libcrm114/files/patch-clang-fno-common
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2020-10-08 11:53:30 UTC
Committed,

Thanks!