Bug 250393

Summary: net-im/telegram-desktop: update to 2.4.3 (incomplete)
Product: Ports & Packages Reporter: Volodymyr Kostyrko <arcade>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: henry.hu.sh, mikael
Priority: --- Flags: henry.hu.sh: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
few fixes to 2.4.3 (incomplete)
none
patch for 2.4.4 henry.hu.sh: maintainer-approval+

Description Volodymyr Kostyrko 2020-10-16 11:34:44 UTC
Created attachment 218794 [details]
few fixes to 2.4.3 (incomplete)

Tried to patch port but failed. Right now cmake configuration fails on:

--   Package 'rlottie', required by 'virtual:world', not found
CMake Error at cmake/external/webrtc/CMakeLists.txt:11 (find_package):

The package is still there, I'm not sure why cmake can't find it. Otherwise overall patch size shouldn't be that big.
Comment 1 Henry Hu 2020-10-26 01:33:44 UTC
So seems like that now we need to pack rlottie and tg_owt separately.
I've tried to create a port for rlottie and it seems to be simple. The only tricky part is how to set the port version: it has made no release at all.
I'll create ports for them, then go back to this port.
I'll also deal with another problem that video chat crashes the app.
Also, I'll just use 2.4.4.
Comment 2 Volodymyr Kostyrko 2020-10-26 18:40:09 UTC
(In reply to Henry Hu from comment #1)


Big thanks! Actually I'm running DragonFly, so for me last build available just crashes on starting audio/video call. I thought that was our problem...
Comment 3 Henry Hu 2020-10-28 00:44:25 UTC
Created attachment 219158 [details]
patch for 2.4.4

Update to 2.4.4. Noticeable changes:
* Add NDEBUG to CXXFLAGS. This disables DCHECKs and allows video calls to work. Issue reported by Alex V. Petrov.
* Change to cmake for rlottie and tg_owt. When they can be packaged properly, we may revert this patch and use separately packaged ports for them.

Changelog:
2.4.4 (23.10.20)

- Fix application quit on call end with main window hidden in tray.
- Update OpenAL library on Windows.
- Several crash fixes.

2.4.3 (07.10.20)

- Fix sending voice messages in scheduled messages section.
- Fix deleting profile / group / channel photos.
- Several crash fixes.

2.4.2 (02.10.20)

- Allow block, report and delete all message from user from "user joined" service message context menu.
- Fix admin badge display in groups.
- Fix loading and opening of comments in channels.

2.4.1 (01.10.20)

- Move by PageUp and PageDown in channel comments.
- Several layout bugfixes.
- Several crashfixes.

2.4 (30.09.20)

- Turn on "Remain Anonymous" in an admin's Permissions to let them post on behalf of the group and become invisible in the list of members.
- Comment on posts in channels that have a discussion group.
- Get notified about replies to your comments via the new Replies chat (if you are not a member of the discussion group).
Comment 4 Henry Hu 2020-10-28 00:45:20 UTC
(In reply to Volodymyr Kostyrko from comment #2)
Well, audio call is always working, and it should not crash telegram... There's a problem with video call. So you should be able to start the call, but the moment you enable video, it crashes.
Comment 6 commit-hook freebsd_committer 2020-11-07 18:50:23 UTC
A commit references this bug:

Author: mikael
Date: Sat Nov  7 18:50:07 UTC 2020
New revision: 554414
URL: https://svnweb.freebsd.org/changeset/ports/554414

Log:
  net-im/telegram-desktop: Update to 2.4.4

  Update to 2.4.4. Noticeable changes:
  * Add NDEBUG to CXXFLAGS. This disables DCHECKs and allows video calls to work.
  * Change to cmake for rlottie and tg_owt. When they can be packaged properly,
    we may revert this patch and use separately packaged ports for them.

  Changelog:
  2.4.4 (23.10.20)

  - Fix application quit on call end with main window hidden in tray.
  - Update OpenAL library on Windows.
  - Several crash fixes.

  2.4.3 (07.10.20)

  - Fix sending voice messages in scheduled messages section.
  - Fix deleting profile / group / channel photos.
  - Several crash fixes.

  2.4.2 (02.10.20)

  - Allow block, report and delete all message from user from "user joined"
    service message context menu.
  - Fix admin badge display in groups.
  - Fix loading and opening of comments in channels.

  2.4.1 (01.10.20)

  - Move by PageUp and PageDown in channel comments.
  - Several layout bugfixes.
  - Several crashfixes.

  2.4 (30.09.20)

  - Turn on "Remain Anonymous" in an admin's Permissions to let them post on behalf
    of the group and become invisible in the list of members.
  - Comment on posts in channels that have a discussion group.
  - Get notified about replies to your comments via the new Replies chat (if you
    are not a member of the discussion group).

  PR:		250393
  Submitted by:	Henry Hu (maintainer)
  Reported by:	Volodymyr Kostyrko

Changes:
  head/net-im/telegram-desktop/Makefile
  head/net-im/telegram-desktop/distinfo
  head/net-im/telegram-desktop/files/patch-Telegram_lib__base_base_platform_linux_base__info__linux.cpp
  head/net-im/telegram-desktop/files/patch-cmake_external_rlottie_CMakeLists.txt
  head/net-im/telegram-desktop/files/patch-cmake_external_webrtc_CMakeLists.txt
  head/net-im/telegram-desktop/files/patch-tg__owt_CMakeLists.txt
  head/net-im/telegram-desktop/files/patch-tg__owt_cmake_init__target.cmake
Comment 7 Mikael Urankar freebsd_committer 2020-11-07 18:51:04 UTC
Thanks!