Bug 250411

Summary: news/sabnzbdplus: Update to 3.1.1
Product: Ports & Packages Reporter: James French <james>
Component: Individual Port(s)Assignee: Adam Weinberger <adamw>
Status: In Progress ---    
Severity: Affects Only Me CC: adamw, fernape
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/sabnzbd/sabnzbd/releases/tag/3.1.1
Bug Depends on: 250380    
Bug Blocks:    
Attachments:
Description Flags
Patch to 3.1.0
james: maintainer-approval+
Poudriere build log
none
Patch to 3.1.0 - Update cheroot
none
3.1.0: Fix feedparser hard dependency
none
Update to 3.1.1
none
Poudriere build log none

Description James French 2020-10-17 02:43:36 UTC
Created attachment 218821 [details]
Patch to 3.1.0

Maintainer update, 3.1.0 release.

Important note on Feedparser:

The Feedparser option is currently broken (requires feedparser >= 6.0.0). I have submitted a patch against bug 250380 to bring feedparser up to date (6.0.1).

The port otherwise works fine.
Comment 1 James French 2020-10-17 02:48:15 UTC
Created attachment 218822 [details]
Poudriere build log
Comment 2 Fernando ApesteguĂ­a freebsd_committer 2020-10-19 14:27:56 UTC
^Triage: Bugfix release, merge to quarterly branch.

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.


Thanks!
Comment 3 James French 2020-10-23 17:28:27 UTC
Created attachment 219010 [details]
Patch to 3.1.0 - Update cheroot

Upstream were holding with a dependency of <= 8.4.3 on www/py-cheroot due to a bug in 8.4.4.

8.4.5 has hit the ports tree, and has a fix but may have an additional regression. Updating the patch to be without the dependency issue.

Previous versions of sabnzbd would be similarly affected, so we'll see if anyone has issues and go from there.
Comment 4 commit-hook freebsd_committer 2020-10-26 19:46:41 UTC
A commit references this bug:

Author: adamw
Date: Mon Oct 26 19:45:48 UTC 2020
New revision: 553378
URL: https://svnweb.freebsd.org/changeset/ports/553378

Log:
  news/sabnzbdplus: Update to 3.1.0

  PR:		250411
  Submitted by:	maintainer

Changes:
  head/news/sabnzbdplus/Makefile
  head/news/sabnzbdplus/distinfo
  head/news/sabnzbdplus/pkg-plist
Comment 5 Adam Weinberger freebsd_committer 2020-10-26 19:48:36 UTC
I've committed the patch here, but I'm holding off on the MFH until we know there's no fallout from the regressions you mentioned.

James, when you feel confident that it's safe to MFH, please let me know (or if you think this update doesn't need to be merged to quarterly).
Comment 6 James French 2020-10-27 03:39:06 UTC
(In reply to Adam Weinberger from comment #5)

Ok, I've had a deeper dive through the issues, and I think what's left is log spam only and should be safe for this port.

If anyone stumbles across this, the relevant upstream issues are:
SabNZB: https://github.com/sabnzbd/sabnzbd/issues/1572
Cheroot: https://github.com/cherrypy/cheroot/issues/317

Cheroot 8.4.4 had a crash caused by a threading race condition. 8.4.5 the crash is resolved, but the race condition is still there which may cause log spam. No fix available yet but upstream SabNZB have given the ok on 8.4.5.

In either case, the quarterly branch is on 8.4.3 which is safe from both issues. 

This version resolves a number of issues with SabNZB so merging quarterly is probably a good idea.

Cheers
Comment 7 commit-hook freebsd_committer 2020-10-27 13:41:49 UTC
A commit references this bug:

Author: adamw
Date: Tue Oct 27 13:41:25 UTC 2020
New revision: 553440
URL: https://svnweb.freebsd.org/changeset/ports/553440

Log:
  MFH: r553378
  Approved by:	portmgr (with hat)

  news/sabnzbdplus: Update to 3.1.0

  PR:		250411
  Submitted by:	maintainer

Changes:
_U  branches/2020Q4/
  branches/2020Q4/news/sabnzbdplus/Makefile
  branches/2020Q4/news/sabnzbdplus/distinfo
  branches/2020Q4/news/sabnzbdplus/pkg-plist
Comment 8 James French 2020-10-27 22:56:34 UTC
Created attachment 219156 [details]
3.1.0: Fix feedparser hard dependency

An oversight on my part, feedparser is still in the default options list, but the patch to 6.0.1 on bug 250380 is still pending maintainer approval with still another 3 days before timeout.

Builds are failing with the default option set.

Further to that, it looks like this version has made feedparser a hard requirement too so just disabling the option introduces a runtime problem.

Attached makes feed parser a hard dependency, but the port will be broken until the other bug is resolved. I am wondering if rolling back sabnzbd makes more sense at this time.
Comment 9 Adam Weinberger freebsd_committer 2020-10-27 23:22:45 UTC
Ugh. I don't know why my poudriere was happy with this before commit.

What is the state of bug 250380? Your last comment in there talks about marking the port broken. Is the patch ready for commit (maintainer approval aside)?
Comment 10 Adam Weinberger freebsd_committer 2020-10-27 23:35:51 UTC
Ok well, sbz was never added to that PR so really the timeout period should probably start from today. I'll back this out of head and quarterly.
Comment 11 commit-hook freebsd_committer 2020-10-27 23:38:26 UTC
A commit references this bug:

Author: adamw
Date: Tue Oct 27 23:37:38 UTC 2020
New revision: 553512
URL: https://svnweb.freebsd.org/changeset/ports/553512

Log:
  news/sabnzbdplus: Back out r553378

  Feedburner needs to be a hard dependency, and the version currently
  in ports is incompatible.

  PR:		250411, 250380

Changes:
  head/news/sabnzbdplus/Makefile
  head/news/sabnzbdplus/distinfo
  head/news/sabnzbdplus/pkg-plist
Comment 12 commit-hook freebsd_committer 2020-10-27 23:39:30 UTC
A commit references this bug:

Author: adamw
Date: Tue Oct 27 23:38:36 UTC 2020
New revision: 553513
URL: https://svnweb.freebsd.org/changeset/ports/553513

Log:
  MFH: r553512
  Approved by:	portmgr (with hat)

  news/sabnzbdplus: Back out r553378

  Feedburner needs to be a hard dependency, and the version currently
  in ports is incompatible.

  PR:		250411, 250380

Changes:
_U  branches/2020Q4/
  branches/2020Q4/news/sabnzbdplus/Makefile
  branches/2020Q4/news/sabnzbdplus/distinfo
  branches/2020Q4/news/sabnzbdplus/pkg-plist
Comment 13 James French 2020-10-27 23:57:33 UTC
(In reply to Adam Weinberger from comment #9)

> Ugh. I don't know why my poudriere was happy with this before commit.

Mine was too, but I might have had the 6.0.1 feedparser patch in my overlay ports tree which was a mistake.

I did set this bug as depending on bug 250380, but it broke considerably more spectacularly than I was expecting.

> Your last comment in there talks about marking the port broken. Is the patch ready for commit (maintainer approval aside)?

Ready to go aside from the clean-up you've identified which I'll fix now. The "broken" aspect is that the latest version of feedparser requires shipping a Python 2 standard library that has had 2to3 run on it. If we don't do that, the port is broken, if we do (which is a bit messy) it works fine. There's no getting around that unfortunately as upstream have yet to port the code properly to Python 3.
Comment 14 James French 2020-11-12 05:53:38 UTC
Created attachment 219582 [details]
Update to 3.1.1

3.1.1 has been released, updating this patch. Still pending Feedparser update to >= 6.0.0 before this can be committed, see bug 250380
Comment 15 James French 2020-11-12 05:54:24 UTC
Created attachment 219583 [details]
Poudriere build log