Bug 250460
| Summary: | devel/lua-lgi: disable 5.4 build for now | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrew "RhodiumToad" Gierth <andrew> | ||||||
| Component: | Individual Port(s) | Assignee: | Kyle Evans <kevans> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | kevans, ports-bugs | ||||||
| Priority: | --- | Keywords: | buildisok, patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/204608604 Created attachment 218886 [details]
devel/lua-lgi patch to disable 5.4 build and fix depends
Contrary to previous comment, it turns out that this port does directly reference libffi, so include the previously omitted LIB_DEPENDS (which previously failed to fail because gnome libs pull this in too).
PORTREVISION bump for change in dependencies.
Now passes stage-qa.
While here, pet portclippy.
A commit references this bug: Author: kevans Date: Sun Oct 25 17:20:51 UTC 2020 New revision: 553277 URL: https://svnweb.freebsd.org/changeset/ports/553277 Log: devel/lua-lgi: disable 5.4 build for now Upstream releases do not currently build with Lua 5.4 due to lua_resume api changes, and upsteam master doesn't currently work properly with Lua 5.4. While here, appease stage-qa and fix the LIB_DEPENDS -- this port does directly depend on libffi. Also pet portclippy (reorganization). PORTREVISION bumped due to the dependency change. PR: 250460 Submitted by: Andrew Gierth <andrew tao11 riddles org uk> (maintainer) Changes: head/devel/lua-lgi/Makefile Committed, thanks! |
Created attachment 218885 [details] devel/lua-lgi patch to disable 5.4 build Upstream master does not work properly yet on 5.4, and upstream releases don't build on 5.4. (lua_resume api changes) No PORTREVISION bump because nothing changes on any pre-5.4 version and no 5.4 version was ever built. Per pkg-fallout. Tested for build on 5.3 and earlier. (Errors in stage-qa because of pre-existing issues with Uses/gnome.mk vs. libffi that are outside the scope of this port.)