Bug 250473
| Summary: | graphics/mupdf: update to 1.18.0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Zsolt Udvari <uzsolt> | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | fernape, uzsolt | ||||||
| Priority: | --- | Keywords: | easy, patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://mupdf.com/release_history.html | ||||||||
| Attachments: |
|
||||||||
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] Thanks! (In reply to Fernando Apesteguía from comment #1) Sorry, I forgot it. Created attachment 218938 [details]
Additional improvements in port Makefile
When building:
====> Running Q/A tests (stage-qa)
Warning: Possible REINPLACE_CMD issues:
- - REINPLACE_CMD ran, but did not modify file contents: Makerules
- - REINPLACE_CMD ran, but did not modify file contents: Makerules
- - REINPLACE_CMD ran, but did not modify file contents: Makethird
Makethird does not containt the variable to be replaced. The other one can be combined in a single REINPLACE_CMD command.
Would you mind checking the new patch?
Thanks
(In reply to Fernando Apesteguía from comment #3) I did notice it. My idea was if later appears again '-pipe' (and others) in Makerules don't need modify again. Do you think should remove these lines? (In reply to Zsolt Udvari from comment #4) Well, I removed the post-patch block completely and it builds and runs fine. What was the purpose of removing -pipe -O2 in the first place? I think it was not me. Maybe the first appear here: https://svnweb.freebsd.org/ports/head/graphics/mupdf/Makefile?r1=257611&r2=258737 The reason I think the "Respect CFLAGS": https://www.freebsd.org/doc/en/books/porters-handbook/book.html#dads-cflags (In reply to Zsolt Udvari from comment #6) In that case I will commit the version with the post-patch reworked. Thanks! (In reply to Fernando Apesteguía from comment #7) Okay, thanks! A commit references this bug: Author: fernape Date: Thu Oct 22 05:36:23 UTC 2020 New revision: 552929 URL: https://svnweb.freebsd.org/changeset/ports/552929 Log: graphics/mupdf: update to 1.18.0 ChangeLog: https://mupdf.com/release_history.html While here rework post-patch and remove noop REINPLACE_CMD PR: 250473 Submitted by: uzsolt@uzsolt.hu (maintainer) Changes: head/graphics/mupdf/Makefile head/graphics/mupdf/distinfo head/graphics/mupdf/files/patch-Makefile head/graphics/mupdf/pkg-plist Committed, Thanks! |
Created attachment 218903 [details] diff to 1.18.0 Simple update to 1.18.0.