Summary: | net/grive2: Merge upstream changes to fix OAuth quota limitation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Samuel Andersen <samuel> | ||||||
Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Many People | CC: | lwhsu | ||||||
Priority: | --- | Flags: | lwhsu:
merge-quarterly+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Samuel Andersen
2020-10-22 16:30:14 UTC
Thanks for the reporting, as currently there is no dedicated maintainer of this port, can you try to provide a patch to fix this issue? Created attachment 219012 [details]
Patch to merge upstream changes
(In reply to Li-Wen Hsu from comment #1) Hi Li-Wen, I've uploaded a patch here. This is my first time going through the process, so would appreciate any feedback on this. Thanks! (In reply to Samuel Andersen from comment #3) Hi Samuel, Thanks for working on a patch. It generally looks excellent. There are some minor points: - Because DISTVERSION is increased, PORTREVISION doesn't need to be bumped, and needs to be cleared. Just removing PORTREVISION line is fine. - You mentioned that the line number of OS.hh needs to be updated, but it doesn't include in the patch. And there are two additional things hope you can consider: - The local modification of OS.hh looks a good candidate to be upstreamed. Do you want to create a PR for it? - As there is no maintainer of this port and you have good progress of it. May I encourage you taking the maintainership of this port? Created attachment 219042 [details]
Updated patch to merge upstream changes
(In reply to Li-Wen Hsu from comment #4) Hi Li-Wen, I have updated the patch and created a PR, linked here: https://github.com/vitalif/grive2/pull/328 I was mistaken with my original comment about line number in OS.hh. I've gone ahead and ensured that patching works and the build finishes correctly without changing any line number. I also updated the package maintainer to my own email address. I'm not sure if there's any additional action needed on my end to accept maintainership. Thanks! A commit references this bug: Author: lwhsu Date: Sat Oct 24 19:31:23 UTC 2020 New revision: 553220 URL: https://svnweb.freebsd.org/changeset/ports/553220 Log: net/grive2: Update to 0.5.2-dev to fix OAuth quota limitation issue Pass maintainership to the submitter PR: 250534 Submitted by: Samuel Andersen <samuel@andersentech.net> MFH: 2020Q4 Changes: head/net/grive2/Makefile head/net/grive2/distinfo head/net/grive2/files/patch-CMakeLists.txt (In reply to Samuel Andersen from comment #6) Thanks very much! A commit references this bug: Author: lwhsu Date: Mon Oct 26 00:44:03 UTC 2020 New revision: 553311 URL: https://svnweb.freebsd.org/changeset/ports/553311 Log: MFH: r553220 net/grive2: Update to 0.5.2-dev to fix OAuth quota limitation issue Pass maintainership to the submitter PR: 250534 Submitted by: Samuel Andersen <samuel@andersentech.net> Approved by: ports-secteam (fluffy) Changes: _U branches/2020Q4/ branches/2020Q4/net/grive2/Makefile branches/2020Q4/net/grive2/distinfo branches/2020Q4/net/grive2/files/patch-CMakeLists.txt |