Bug 250601
| Summary: | [NEW PORT] security/py-onlykey: command line tool to work with OnlyKey hardware password manager | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmytro Bilokha <dmytro> | ||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | diizzy, fernape, pi | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dmytro Bilokha
2020-10-25 17:23:01 UTC
^Triage: Maintainer-feedback flag (+) not required unless requested (?) first ^Triage: Why is PORTREVISION set? Thanks! Are dependencies correct? Upstream's list is different, https://github.com/trustcrypto/python-onlykey/blob/master/setup.py#L26 Sample file is defined incorrectly https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config Does it pass portlint and poudriere? https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-testing Created attachment 219078 [details]
security/py-onlykey port, with removed PORTREVISION
Sorry, it is my copy-past error from another Python port. Here I attach fixed patch with removed PORTREVISION
(In reply to daniel.engberg.lists from comment #2) Sorry, seems like I did it wrong. 1. The dependencies list is incorrect, I'll fix it. 2. I din't get why the plist is not correct? In the Makefile I have: USE_PYTHON= autoplist distutils PLIST_FILES= "${PREFIX}/etc/devd/onlykey.conf.sample" "${PREFIX}/man/man1/onlykey-cli.1.gz" My intention is to have in the PLIST all the files generated by Python autoplist and two additional files created by me: sample and manpage. How to achive this in correct way? 3. The port passes make stage/stage-qa/package/install/deinstall in a separate jail. I'll do additional checks after fixing the issues mentioned above. Thanks for your comments and sorry for my mistakes. Its my second port and the only first with Python. Created attachment 219257 [details]
V3 The new port patch with issues fixed
Here I attach the new patch with all the issues fixed. It passes both portlint and poudriere testport. Please, take a look. Thank you!
Hi guys, I've submitted the new patch with issues fixed. Could you, please, take a look? Testbuilds@work Committed, thanks! A commit references this bug: Author: pi Date: Thu Dec 10 21:29:43 UTC 2020 New revision: 557479 URL: https://svnweb.freebsd.org/changeset/ports/557479 Log: New port: security/py-onlykey: cli for the OnlyKey hardware password manager Python command line tool for configuring and using the OnlyKey hardware password manager. WWW: https://github.com/trustcrypto/python-onlykey PR: 250601 Submitted by: Dmytro Bilokha <dmytro@posteo.net> Changes: head/security/Makefile head/security/py-onlykey/ head/security/py-onlykey/Makefile head/security/py-onlykey/distinfo head/security/py-onlykey/files/ head/security/py-onlykey/files/onlykey-cli.1 head/security/py-onlykey/files/onlykey.conf.sample head/security/py-onlykey/files/pkg-message.in head/security/py-onlykey/pkg-descr |
