Summary: | audio/exhale: Update to 1.0.8 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||
Component: | Individual Port(s) | Assignee: | Rainer Hurling <rhurlin> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | rhurlin | ||||||
Priority: | --- | Keywords: | buildisok | ||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://gitlab.com/ecodis/exhale/-/releases/v1.0.8 | ||||||||
Attachments: |
|
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/210004490 Hi Daniel, Thanks for the patch. The patch builds and installs correctly. Also the coding seems to work as expected :) I wonder if the license is described correctly enough. Instead of a BSD3CLAUSE (not BSD!) license it seems to be a separate, BSD modified license[1][2]. Therefore I suggest to change the license section. This should be briefly approved by the author. [1] https://gitlab.com/ecodis/exhale#license [2] https://gitlab.com/ecodis/exhale/-/blob/master/include/License.htm (In reply to Rainer Hurling from comment #2) Oops, forgot to add the suggest license part: LICENSE= EXHALE LICENSE_NAME= exhale Copyright License LICENSE_FILE= ${WRKSRC}/include/License.htm LICENSE_PERMS= dist-mirror dist-sell pkg-mirror pkg-sell auto-accept Created attachment 219293 [details]
Patch for exhale v2
Update license information per suggestion by rhurlin@
Patch updated, thanks! A commit references this bug: Author: rhurlin Date: Mon Nov 2 06:36:55 UTC 2020 New revision: 553886 URL: https://svnweb.freebsd.org/changeset/ports/553886 Log: audio/exhale: Update to 1.0.8 From the changelog[1]: - minor quality improvements at low and high rates, some license text clarifications - exhaleApp: slightly improved loudness calculation for low and high sampling rates - exhaleLib: improved audio quality a bit for the lower and higher-rate CVBR modes - License: removed references to BSD text, clarified disclaimer and contributor text [1] https://gitlab.com/ecodis/exhale/-/releases/v1.0.8 PR: 250748 Submitted by: Daniel Engberg <daniel.engberg.lists@pyret.net> (maintainer) Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D27051 Changes: head/audio/exhale/Makefile head/audio/exhale/distinfo Committed, thanks :) |
Created attachment 219228 [details] Patch for exhale Update exhale to 1.0.8 Compile and run tested on FreeBSD 13.0-CURRENT #0 r364979 (amd64)