|Summary:||New port: www/dooble: A qt5-webengine based browser, minimal, cute, and unusually stable.|
|Product:||Ports & Packages||Reporter:||Eric Camachat <eric>|
|Component:||Individual Port(s)||Assignee:||Li-Wen Hsu <lwhsu>|
|Severity:||Affects Only Me||CC:||bobf, daniel.engberg.lists, eric, lwhsu|
Description Eric Camachat 2020-11-04 05:57:10 UTC
Created attachment 219348 [details] New port: www/dooble web browser. Dooble, the weather bug browser. Minimal, cute, and unusually stable. - A Web browser! - Basic themes. - Compact. - Cookie crusher. - Custom search engines. - Custom style sheets. - Documented. - Domain restrictions. - Favorites. - Floating digital clock. - FreeBSD, Linux, Mac, Windows. - Gopher support. - Multiple private instances, including downloads. - Original implementations of AES-256, Threefish-256. - Qt-only dependency. - Windows portable. WWW: https://textbrowser.github.io/dooble/
Comment 1 daniel.engberg.lists 2020-11-04 06:38:58 UTC
Looks good a first glance but I don't think you should override ports framework regarding CFLAGS such as optimization at least not by default and removing flags such as -std=c++11 may cause compilation issues on some platforms. Is it really a good idea to strip pretty much everything upstream sets?
Comment 2 Eric Camachat 2020-11-04 06:58:03 UTC
(In reply to daniel.engberg.lists from comment #1) OK, I will remove optimization flags which should get from ports system and flags that fail compiling.
Comment 3 Eric Camachat 2020-11-04 07:00:25 UTC
Created attachment 219349 [details] Only remove optimization CXXFLAGS and flags that fail compiling.
Comment 4 Li-Wen Hsu 2020-11-06 05:38:06 UTC
Created attachment 219389 [details] dooble.diff I've adjust the patch a little bit to make `portlint -abct` happy, please check it. Thanks!
Comment 5 Bob Frazier 2020-11-08 17:35:23 UTC
you might want to assign QT5_VERSION since changes to QT could cause build failures. I actually attempted to build this (by setting up a test port using your diff) but using an older QT (5.13.0) and there were some build errors, apparently due to name changes in the QT web stuff. That being the case, 3rd party dependencies like QT can become moving targets and cause build failures. I've seen the "moving target" problem with other massive libraries, and setting QT5_VERSION might give you a heads up on this. The current (2020 Q4) value (from Uses/qt.mk) is "5.15.0", FYI
Comment 6 Bob Frazier 2020-11-08 17:42:37 UTC
(In reply to my own from comment #5) actually may be better to check, rather than assign, QT5_VERSION since the ports make environment doesn't seem to do the version checks. it does use a '?=' to assign it to the current version, which I would think implies that you can assign it to something else. But since it's not obvious (to me anyway) where this is being checked, if at all, it's probably better to check for it and compare the version to whatever you know actually builds, and warn (or fail or apply additional patches) for anything else.
Comment 7 Eric Camachat 2020-11-08 19:27:04 UTC
Created attachment 219471 [details] Add QT5 minor version check Add QT5 minor version check.
Comment 8 Eric Camachat 2020-11-10 17:18:59 UTC
Created attachment 219526 [details] Fix QT5 minor version check
Comment 9 Eric Camachat 2021-02-23 22:03:14 UTC
Created attachment 222771 [details] Update to version 2021.01.10