Bug 250879
| Summary: | math/gfan: requesting maintainership | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Moritz Schmitt <moritz> | ||||||
| Component: | Individual Port(s) | Assignee: | Mikael Urankar <mikael> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | fernape, mikael | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Moritz Schmitt
2020-11-05 13:16:45 UTC
Hi Moritz, Thanks for stepping up. Could you please attach a patch for this? Please find attached a patch for math/gfan. This patch introduces the following changes:
o Update URL in MASTER_SITES to current address
o Update MAINTAINER
o Remove post-patch target as it is not needed
- Use LDFLAGS instead of the non-standard variable
ADDITIONALLINKOPTIONS.
- Replace "${REINPLACE_CMD} 's,log2,gfan_log2,g'" by appropriate
patch files as the command triggers multiple warnings. log2 is
a macro defined in src/log.h. The name of this macro is in
conflict with the function log2 from math.h. To avoid errors
when compiling the code, the above renaming is necessary.
Furthermore, PHB 4.4.3 strongly suggests using patch files
instead of REINPLACE_CMD for static content.
o Sort pkg-plist alphabetically as required by PHB 3.2.2
o Shorten pkg-descr and make it less technical
Created attachment 220098 [details]
Patch for math/gfan
Created attachment 220099 [details]
Poudriere test log
A commit references this bug: Author: mikael Date: Fri Dec 4 18:17:39 UTC 2020 New revision: 556996 URL: https://svnweb.freebsd.org/changeset/ports/556996 Log: math/gfan: pass maintainership o Update URL in MASTER_SITES to current address o Update MAINTAINER o Remove post-patch target as it is not needed - Use LDFLAGS instead of the non-standard variable ADDITIONALLINKOPTIONS. - Replace "${REINPLACE_CMD} 's,log2,gfan_log2,g'" by appropriate patch files as the command triggers multiple warnings. log2 is a macro defined in src/log.h. The name of this macro is in conflict with the function log2 from math.h. To avoid errors when compiling the code, the above renaming is necessary. Furthermore, PHB 4.4.3 strongly suggests using patch files instead of REINPLACE_CMD for static content. o Sort pkg-plist alphabetically as required by PHB 3.2.2 o Shorten pkg-descr and make it less technical PR: 250879 Submitted by: Moritz Schmitt (maintainer) Changes: head/math/gfan/Makefile head/math/gfan/files/patch-src_app__doesidealcontain.cpp head/math/gfan/files/patch-src_app__fiberpolytope.cpp head/math/gfan/files/patch-src_app__groebnerfan.cpp head/math/gfan/files/patch-src_app__main.cpp head/math/gfan/files/patch-src_app__resultantfan.cpp head/math/gfan/files/patch-src_app__secondaryfan.cpp head/math/gfan/files/patch-src_app__tropicalintersection.cpp head/math/gfan/files/patch-src_app__tropicaltraverse.cpp head/math/gfan/files/patch-src_bergman.cpp head/math/gfan/files/patch-src_breadthfirstsearch.cpp head/math/gfan/files/patch-src_buchberger.cpp head/math/gfan/files/patch-src_codimoneconnectedness.cpp head/math/gfan/files/patch-src_enumeration.cpp head/math/gfan/files/patch-src_ep__xfig.cpp head/math/gfan/files/patch-src_field__rationals.cpp head/math/gfan/files/patch-src_gfanlib__polyhedralfan.cpp head/math/gfan/files/patch-src_gfanlib__symmetriccomplex.cpp head/math/gfan/files/patch-src_gfanlib__zfan.cpp head/math/gfan/files/patch-src_halfopencone.cpp head/math/gfan/files/patch-src_linalg.cpp head/math/gfan/files/patch-src_log.h head/math/gfan/files/patch-src_lp__soplexcdd.cpp head/math/gfan/files/patch-src_padic.cpp head/math/gfan/files/patch-src_polyhedralcone.cpp head/math/gfan/files/patch-src_polyhedralfan.cpp head/math/gfan/files/patch-src_reversesearch.cpp head/math/gfan/files/patch-src_singular.cpp head/math/gfan/files/patch-src_symmetriccomplex.cpp head/math/gfan/files/patch-src_symmetry.cpp head/math/gfan/files/patch-src_traverser__stableintersection.cpp head/math/gfan/files/patch-src_traverser__tropical.cpp head/math/gfan/files/patch-src_triangulation2.h head/math/gfan/files/patch-src_tropical.cpp head/math/gfan/files/patch-src_tropical2.cpp head/math/gfan/files/patch-src_tropical__weildivisor.cpp head/math/gfan/files/patch-src_tropicalbasis.cpp head/math/gfan/files/patch-src_tropicalcurve.cpp head/math/gfan/files/patch-src_tropicaltraverse.cpp head/math/gfan/files/patch-src_wallideal.cpp head/math/gfan/pkg-descr head/math/gfan/pkg-message head/math/gfan/pkg-plist Thanks! |
