Bug 250884
| Summary: | math/cantor: Support ptyhon3.9 instead of duplicating python 3.6 check | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Oleg Sidorkin <osidorkin> | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | tcberner | ||||||||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Moin moin Yes, I looked at patching it similarly recently. I think it would be preferable however, if we added a %%PYTHON%% as first entry in the cmake and replace that with the version used by the framework, which should make it a bit more robust and future proof. mfg Tobias Created attachment 219374 [details]
v2
Could you try this one?
(In reply to Tobias C. Berner from comment #2) (had to apply in manually) Cantor fails to install with this patch for me. I think it's because of missing "-e '/pkg_check_modules/s,python3,python-${PYTHON_VER},' \" part. If I add this part to the Makefile, cantor installs ok. Created attachment 219375 [details]
v3
(In reply to Tobias C. Berner from comment #4) This gives us "pkg_check_modules(PYTHONLIBS3 QUIET python3.9)" instead of "pkg_check_modules(PYTHONLIBS3 QUIET python-3.9)" Created attachment 219377 [details]
v4
I think we're getting there :D
(In reply to Tobias C. Berner from comment #6) (obvisouly ignore the python:3.9+ hunk :) -- but at least now you know I tested this one :D ) (In reply to Tobias C. Berner from comment #6) Yes. It works now. :) Thanks a lot for looking on it. A commit references this bug: Author: tcberner Date: Thu Nov 5 18:49:12 UTC 2020 New revision: 554148 URL: https://svnweb.freebsd.org/changeset/ports/554148 Log: math/cantor: Support ptyhon3.9 - instead of adding 'python3.9' to the list, simply patch in python-${PYTHON_VER} -- this way, this should fix two issues 1) make it work with python 2) help cmake find the "wanted" python version in unclean environments PR: 250884 Reported by: Oleg Sidorkin <osidorkin@gmail.com>, fluffy (previously) Changes: head/math/cantor/Makefile head/math/cantor/files/ head/math/cantor/files/patch-cmake_FindPythonLibs3.cmake Thanks for testing :) A commit references this bug: Author: tcberner Date: Fri Nov 6 04:45:21 UTC 2020 New revision: 554167 URL: https://svnweb.freebsd.org/changeset/ports/554167 Log: MFH: r554148 math/cantor: Support ptyhon3.9 - instead of adding 'python3.9' to the list, simply patch in python-${PYTHON_VER} -- this way, this should fix two issues 1) make it work with python 2) help cmake find the "wanted" python version in unclean environments PR: 250884 Reported by: Oleg Sidorkin <osidorkin@gmail.com>, fluffy (previously) Approved by: ports-secteam (implicit) Changes: _U branches/2020Q4/ branches/2020Q4/math/cantor/Makefile branches/2020Q4/math/cantor/files/ |
Created attachment 219373 [details] svn diff to fix python3.9 detection in math/cantor Cantor upstream is checking for python3.6 itself now, however it is missing python3.9 check. So if DEFAULT_VERSIONS+=python3=3.9 is set and earlier version of python is not installed math/cantor fails to detect python. Then it fails to install because of missing files listed in pkg-plist. In the proposed patch REINPLACE_CMD args are ajusted to add python3.9 support (and stop duplicating python3.6 entry)