Bug 250990
| Summary: | graphics/blender and graphics/openshadinglanguage: respect LLVM_DEFAULT | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> | ||||||
| Component: | Individual Port(s) | Assignee: | Dima Panov <fluffy> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | FreeBSD, fluffy | ||||||
| Priority: | --- | Flags: | FreeBSD:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
This is a good workable idea. Small change, I would take out the .include <bsd.port.pre.mk> - in porters handbook 5.13 (see paragragh above example 5.39) it sounds to me like bsd.port.options.mk is preferred over bsd.port.pre.mk and is meant to replace it. And if we keep .include <bsd.port.pre.mk>, the last line needs to change to .include <bsd.port.post.mk> Porters handbook 13.5 -> Important: Include either the bsd.port.pre.mk/bsd.port.post.mk pair or bsd.port.mk only; do not mix these two usages. (In reply to Shane from comment #1) Do you want me to fix my patch or will you fix it yourself? It would be easier for you to update your patch Created attachment 219558 [details] Make graphics/blender and graphics/openshadinglanguage respect LLVM_DEFAULT (In reply to Shane from comment #3) Replaced with bsd.port.options.mk. (In reply to Shane from comment #3) Something wrong with patch? I would approve the patch if it would let me. I meant to do that earlier. Comment on attachment 219558 [details]
Make graphics/blender and graphics/openshadinglanguage respect LLVM_DEFAULT
see if a commment helps
(In reply to Shane from comment #7) Can you, plz, approve patch too? A commit references this bug: Author: fluffy Date: Tue Nov 17 02:10:43 UTC 2020 New revision: 555532 URL: https://svnweb.freebsd.org/changeset/ports/555532 Log: graphics/blender and graphics/openshadinglanguage: respect LLVM_DEFAULT PR: 250990 Submitted by: vvd@unislabs.com Approved by: maintainer Changes: head/graphics/blender/Makefile head/graphics/openshadinglanguage/Makefile Committed, thanks! |
Created attachment 219497 [details] Make graphics/blender and graphics/openshadinglanguage respect LLVM_DEFAULT Build and run fine with llvm10 on 12.1-p10 amd64.