Bug 25106

Summary: "pkg_version -c" should "make install clean" ?
Product: Ports & Packages Reporter: Tim Bishop <tdb>
Component: Individual Port(s)Assignee: Bruce A. Mah <bmah>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Tim Bishop freebsd_committer freebsd_triage 2001-02-15 03:50:00 UTC 
	pkg_version -c, in my opinion, should do "make install clean"
	as the last line, rather than just "make install". Cluttered
	ports trees take up precious space, and if pkg_version is used
	in a scripted environment it could devour space unnoticed.

Fix: 

%diff pkg_version.old pkg_version.new
	468c468
	< make install
	---
	> make install clean
	%
How-To-Repeat: 
	%pkg_version -c
	#
	#  mozilla
	#  needs updating (index has 0.7_1,1)
	#
	cd /usr/ports/www/mozilla
	make && pkg_delete -f mozilla-0.7,1
	make install
	
	%

	In my opinion, that last line should read;

	make install clean
Comment 1 dwcjr 2001-02-15 03:57:35 UTC 
might you want it to do make clean install clean ?
----- Original Message ----- 
From: <tim@bishnet.net>
To: <FreeBSD-gnats-submit@freebsd.org>
Sent: Wednesday, February 14, 2001 9:48 PM
Subject: ports/25106: pkg_version 


> 
> >Number:         25106
> >Category:       ports
> >Synopsis:       "pkg_version -c" should "make install clean" ?
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    freebsd-ports
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          change-request
> >Submitter-Id:   current-users
> >Arrival-Date:   Wed Feb 14 19:50:00 PST 2001
> >Closed-Date:
> >Last-Modified:
> >Originator:     T.D.Bishop
> >Release:        FreeBSD 4.2-STABLE i386
> >Organization:
> n/a
> >Environment:
> >Description:
> 
> pkg_version -c, in my opinion, should do "make install clean"
> as the last line, rather than just "make install". Cluttered
> ports trees take up precious space, and if pkg_version is used
> in a scripted environment it could devour space unnoticed. 
> 
> >How-To-Repeat:
> 
> %pkg_version -c
> #
> #  mozilla
> #  needs updating (index has 0.7_1,1)
> #
> cd /usr/ports/www/mozilla
> make && pkg_delete -f mozilla-0.7,1
> make install
> 
> %
> 
> In my opinion, that last line should read;
> 
> make install clean
> 
> >Fix:
> 
> %diff pkg_version.old pkg_version.new
> 468c468
> < make install
> ---
> > make install clean
> %
> 
> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-ports" in the body of the message
>
Comment 2 tdb1 2001-02-15 04:09:57 UTC 
No, because the line before actually compiles, and thus doing make clean
install clean would compile it twice. Maybe an extra clean near the
beginning though.

On Wed, 14 Feb 2001, David W. Chapman Jr. wrote:

> might you want it to do make clean install clean ?
> ----- Original Message ----- 
> From: <tim@bishnet.net>
> To: <FreeBSD-gnats-submit@freebsd.org>
> Sent: Wednesday, February 14, 2001 9:48 PM
> Subject: ports/25106: pkg_version 
> 
> 
> > 
> > >Number:         25106
> > >Category:       ports
> > >Synopsis:       "pkg_version -c" should "make install clean" ?
> > >Confidential:   no
> > >Severity:       non-critical
> > >Priority:       low
> > >Responsible:    freebsd-ports
> > >State:          open
> > >Quarter:        
> > >Keywords:       
> > >Date-Required:
> > >Class:          change-request
> > >Submitter-Id:   current-users
> > >Arrival-Date:   Wed Feb 14 19:50:00 PST 2001
> > >Closed-Date:
> > >Last-Modified:
> > >Originator:     T.D.Bishop
> > >Release:        FreeBSD 4.2-STABLE i386
> > >Organization:
> > n/a
> > >Environment:
> > >Description:
> > 
> > pkg_version -c, in my opinion, should do "make install clean"
> > as the last line, rather than just "make install". Cluttered
> > ports trees take up precious space, and if pkg_version is used
> > in a scripted environment it could devour space unnoticed. 
> > 
> > >How-To-Repeat:
> > 
> > %pkg_version -c
> > #
> > #  mozilla
> > #  needs updating (index has 0.7_1,1)
> > #
> > cd /usr/ports/www/mozilla
> > make && pkg_delete -f mozilla-0.7,1
> > make install
> > 
> > %
> > 
> > In my opinion, that last line should read;
> > 
> > make install clean
> > 
> > >Fix:
> > 
> > %diff pkg_version.old pkg_version.new
> > 468c468
> > < make install
> > ---
> > > make install clean
> > %
> > 
> > 
> > >Release-Note:
> > >Audit-Trail:
> > >Unformatted:
> > 
> > 
> > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > with "unsubscribe freebsd-ports" in the body of the message
> > 
>
Comment 3 Steve Price freebsd_committer freebsd_triage 2001-02-26 02:03:29 UTC 
Responsible Changed
From-To: freebsd-ports->bmah

Over to maintainer.
Comment 4 Bruce A. Mah freebsd_committer freebsd_triage 2001-04-30 16:38:05 UTC 
State Changed
From-To: open->closed

Committed (as originally submitted).  Thanks for the suggestion/patch, 
and sorry for sitting on it for so long!
Comment 5 Bruce A. Mah freebsd_committer freebsd_triage 2001-04-30 16:39:27 UTC 
State Changed
From-To: closed->suspended

I shouldn't close the PR just yet...I still need to MFC.
Comment 6 Bruce A. Mah freebsd_committer freebsd_triage 2001-05-11 00:51:52 UTC 
State Changed
From-To: suspended->closed

Committed to 4-STABLE, thanks!