Bug 251079

Summary: sysutils/datadog: cleanup
Product: Ports & Packages Reporter: Mikael Urankar <mikael>
Component: Individual Port(s)Assignee: Mikael Urankar <mikael>
Status: Closed FIXED    
Severity: Affects Only Me CC: dch, fernape, uros
Priority: --- Flags: bugzilla: maintainer-feedback? (uros)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://reviews.freebsd.org/D27182
Attachments:
Description Flags
v1
none
archive with latest updates none

Description Mikael Urankar freebsd_committer freebsd_triage 2020-11-12 17:30:01 UTC
Created attachment 219604 [details]
v1
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2020-11-12 17:30:58 UTC
cc dch@
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2020-11-12 17:31:45 UTC
I still wonder why it's named datadog instead of datadog-agent
Comment 3 uros 2020-11-12 17:35:33 UTC
I started with this a few years ago where everything was one big project. But I believe we can name it datadog-agent now since I also plan to add datadog-integrations. And it would make more sense.
Comment 4 uros 2020-11-12 17:41:54 UTC
@mikael can you also check my latest change  on https://github.com/urosgruber/dd-agent-FreeBSD/blob/v7-next/Makefile 
I was trying to build binaries based on options but for unknown reason I can't make it work via ALSO_BUILD variable
Comment 5 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2020-11-13 11:10:53 UTC
^Triage: Reporter is committer, assign accordingly.
Comment 6 uros 2020-11-17 19:14:09 UTC
Patch included is not complete. I've included all the work in the patch and improve some additional fixes. I have latest version available via https://github.com/urosgruber/datadog-agent-FreeBSD

I can prepare a patch based on latest code in the ports.
Comment 7 Mikael Urankar freebsd_committer freebsd_triage 2020-11-29 16:36:39 UTC
(In reply to uros from comment #6)
Do you have other fixes / improvements you want to make or is it ok to commit?
Comment 8 uros 2020-11-29 19:05:54 UTC
Created attachment 220078 [details]
archive with latest updates

This is the latest port that I renamed to datadog-agent. I ran portling as well. But the problem I have it does not want to build with poudriere. Error is something in 

"failed to initialize build cache at /nonexistent/.cache/go-build: mkdir /nonexistent: permission denied"

I was unable to identify why but seems to me that it started when I switched to go:modules

I also have shar file for integration that I can submit.
Comment 9 uros 2020-12-04 20:37:25 UTC
@mikael I think code on github is now ready to be submited. 

I also created a https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251586 for datadog-integrations.
Comment 10 commit-hook freebsd_committer freebsd_triage 2020-12-06 10:31:38 UTC
A commit references this bug:

Author: mikael
Date: Sun Dec  6 10:30:53 UTC 2020
New revision: 557126
URL: https://svnweb.freebsd.org/changeset/ports/557126

Log:
  sysutils/datadog: rename to sysutils/datadog-agent

  Rename to sysutils/datadog-agent
  Various fix / improvements to the port

  PR:		251079
  Submitted by:	uros@gruber.si (maintainer)

Changes:
  head/MOVED
  head/sysutils/Makefile
  head/sysutils/datadog/
  head/sysutils/datadog-agent/
  head/sysutils/datadog-agent/Makefile
  head/sysutils/datadog-agent/distinfo
  head/sysutils/datadog-agent/files/datadog-dogstatsd.in
  head/sysutils/datadog-agent/files/patch-cmd_agent_common_common__nix.go
  head/sysutils/datadog-agent/files/patch-pkg_collector_corechecks_embed_apm__nix.go
  head/sysutils/datadog-agent/files/patch-pkg_collector_corechecks_embed_process__agent.go
  head/sysutils/datadog-agent/files/patch-pkg_collector_corechecks_system_file__handles__freebsd.go
  head/sysutils/datadog-agent/files/patch-pkg_collector_corechecks_system_file__handles__freebsd__test.go
  head/sysutils/datadog-agent/files/patch-pkg_config_log.go
  head/sysutils/datadog-agent/files/patch-pkg_secrets_check__rights__nix.go
  head/sysutils/datadog-agent/files/patch-vendor_github.com_DataDog_gopsutil_disk_disk__freebsd.go
  head/sysutils/datadog-agent/files/patch-vendor_github.com_shirou_gopsutil_disk_disk__freebsd.go
  head/sysutils/datadog-agent/files/pkg-message.in
  head/sysutils/datadog-agent/pkg-descr
  head/sysutils/datadog-agent/pkg-plist
Comment 11 uros 2020-12-06 18:24:07 UTC
Thanks @mikael Looks ok.