Bug 251235
| Summary: | net/py-urllib3: Update to 1.26.2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-python (Nobody) <python> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | dbaio, diizzy, python, swills | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(python) koobs: merge-quarterly? |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/urllib3/urllib3/releases | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250941 | ||||||
| Attachments: |
|
||||||
Thank you for the patch Daniel How does QA go with all dependent ports and www/py-requests in particular? See ports r490937 and ports r517078 for examples of potential issues Please also detail MFH: <branch|no> <reason> with respect to the version delta in the patch, and considering the bugfixes contained between those versions Closing this as I don't have the ability to test this within a foreseeable future (In reply to daniel.engberg.lists from comment #2) I think the version of requests currently in the tree is going to break: https://github.com/psf/requests/blob/v2.22.0/setup.py#L47 but the latest version should be fine: https://github.com/psf/requests/blob/v2.25.1/setup.py#L47 Doing run time testing on all the things that depend on both of them is probably not feasible. Hi Steve, www/py-requests is now at 2.25.1 so it should be good to go? Thanks for keeping an eye on potential breakage Superseded by commit 83ab2b258c5cc11fd3dc89c9fdc0fc69eb39412d |
Created attachment 219788 [details] Patch for urllib3 Update (py-)urllib3 to 1.26.2 FreeBSD 13.0-CURRENT r367711 amd64 (make, make check-plist, make test) Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 11.4-RELEASE (amd64) One test fails on both 1.25.11 and 1.26.2 test/contrib/test_socks.py::TestSocks5Proxy::test_socks_with_invalid_password FAILED