Bug 251271
| Summary: | net-p2p/openethereum: fails to build with clang10 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mikael Urankar <mikael> | ||||||
| Component: | Individual Port(s) | Assignee: | Alex Dupre <ale> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(ale) |
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thanks for the link to a possible patch, but why haven't you tried it to confirm it fixes the issue and it's enough? (In reply to Alex Dupre from comment #1) I'm updating rust to 1.48, I don't have much time / resources to test the mentioned patch: Nov 20 15:41:46 acheron kernel: pid 9880 (rustc), jid 189, uid 0, was killed: out of swap space Nov 20 15:41:48 acheron kernel: pid 14403 (rustc), jid 190, uid 0, was killed: out of swap space Nov 20 15:41:49 acheron kernel: pid 17476 (rustc), jid 211, uid 0, was killed: out of swap space Nov 20 15:41:51 acheron kernel: pid 16765 (rustc), jid 220, uid 0, was killed: out of swap space Nov 20 15:41:52 acheron kernel: pid 91368 (firefox), jid 0, uid 1001, was killed: out of swap space Nov 20 15:41:52 acheron kernel: swp_pager_getswapspace(1): failed Nov 20 15:41:52 acheron kernel: swap_pager: out of swap space Nov 20 15:41:52 acheron kernel: swp_pager_getswapspace(1): failed Nov 20 15:41:52 acheron kernel: swap_pager: out of swap space Nov 20 15:41:52 acheron kernel: swp_pager_getswapspace(3): failed Nov 20 15:42:08 acheron kernel: swap_pager: out of swap space Nov 20 15:42:08 acheron kernel: swp_pager_getswapspace(2): failed Nov 20 15:44:20 acheron kernel: pid 20801 (clang-11), jid 220, uid 0, was killed: out of swap space Nov 20 15:44:33 acheron kernel: pid 20584 (clang-9), jid 190, uid 0, was killed: out of swap space Nov 20 15:44:42 acheron kernel: pid 22269 (clang-9), jid 190, uid 0, was killed: out of swap space Nov 20 15:45:03 acheron kernel: pid 20960 (c++), jid 205, uid 0, was killed: out of swap space Nov 20 15:45:22 acheron kernel: pid 22487 (clang-11), jid 220, uid 0, was killed: out of swap space Nov 20 15:45:34 acheron kernel: pid 23243 (clang-11), jid 211, uid 0, was killed: out of swap space Nov 20 15:45:49 acheron kernel: pid 23217 (clang-11), jid 189, uid 0, was killed: out of swap space Nov 20 15:45:55 acheron kernel: swp_pager_getswapspace(11): failed Nov 20 15:46:16 acheron kernel: pid 23164 (clang-11), jid 189, uid 0, was killed: out of swap space Nov 20 15:46:20 acheron kernel: pid 23166 (clang-11), jid 220, uid 0, was killed: out of swap space Nov 20 15:46:22 acheron kernel: pid 22223 (clang-9), jid 190, uid 0, was killed: out of swap space Nov 20 15:46:25 acheron kernel: pid 23780 (clang-9), jid 190, uid 0, was killed: out of swap space Nov 20 15:46:26 acheron kernel: pid 23516 (clang-11), jid 220, uid 0, was killed: out of swap space Nov 20 15:46:28 acheron kernel: pid 23312 (clang-11), jid 220, uid 0, was killed: out of swap space Created attachment 219831 [details]
v1
it builds fine with the attached patch
Just to know, did you set LLVM_DEFAULT=10 or are you simply using -CURRENT ? Created attachment 219833 [details]
v2
fix build on 11 while here
(In reply to Alex Dupre from comment #4) it's on -current and 11.4, so clang10 by default A commit references this bug: Author: ale Date: Fri Nov 20 18:06:08 UTC 2020 New revision: 555775 URL: https://svnweb.freebsd.org/changeset/ports/555775 Log: Fix build with clang 10 and FreeBSD 11. Remove unused clang build dependency. PR: 251271 Submitted by: mikael Changes: head/net-p2p/openethereum/Makefile head/net-p2p/openethereum/files/ head/net-p2p/openethereum/files/patch-cargo-crates_parity-rocksdb-sys-0.5.6_rocksdb_util_channel.h (In reply to commit-hook from comment #7) FreeBSD 12.1 still uses clang8, I haven't tried if it builds with the stock compiler, maybe llvm9+ is required for this version. I compiled it with 12.1 and clang 8. clang 9 was a leftover from a previous release that required llvm-config, that is not installed in base. (In reply to Alex Dupre from comment #9) Ok FYI, it builds fine on 11.4 i386 and 13 i386 Thanks, I was going to try again, I remove the BROKEN line then. |
In file included from /wrkdirs/usr/ports/net-p2p/openethereum/work/openethereum-3.1.0/cargo-crates/parity-rocksdb-sys-0.5.6/rocksdb/utilities/backupable/backupable_db.cc:16: /wrkdirs/usr/ports/net-p2p/openethereum/work/openethereum-3.1.0/cargo-crates/parity-rocksdb-sys-0.5.6/rocksdb/util/channel.h:35:33: error: no matching constructor for initialization of 'std::lock_guard<std::mutex>' std::lock_guard<std::mutex> lk(lock_); ^ ~~~~~ /usr/include/c++/v1/__mutex_base:90:14: note: candidate constructor not viable: 1st argument ('const std::mutex') would lose const qualifier explicit lock_guard(mutex_type& __m) _LIBCPP_THREAD_SAFETY_ANNOTATION(acquire_capability(__m)) ^ /usr/include/c++/v1/__mutex_base:100:5: note: candidate constructor not viable: no known conversion from 'const std::mutex' to 'const std::__1::lock_guard<std::__1::mutex>' for 1st argument lock_guard(lock_guard const&) _LIBCPP_EQUAL_DELETE; ^ /usr/include/c++/v1/__mutex_base:94:5: note: candidate constructor not viable: requires 2 arguments, but 1 was provided lock_guard(mutex_type& __m, adopt_lock_t) _LIBCPP_THREAD_SAFETY_ANNOTATION(requires_capability(__m)) ^ 1 error generated. probably fixed with: https://github.com/cockroachdb/rocksdb/pull/79