Bug 251318

Summary: multimedia/mpv: removed support of libsmbclient - remove option SMB
Product: Ports & Packages Reporter: Vladimir Druzenko <vvd>
Component: Individual Port(s)Assignee: freebsd-multimedia (Nobody) <multimedia>
Status: Closed FIXED    
Severity: Affects Some People CC: jbeich
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/mpv-player/mpv/blob/v0.33.0/RELEASE_NOTES
Attachments:
Description Flags
remove option SMB vvd: maintainer-approval?

Description Vladimir Druzenko freebsd_committer freebsd_triage 2020-11-22 23:04:39 UTC 
Created attachment 219895 [details]
remove option SMB

> - stream_smb: remove due to lack of thread safety and the abundance
>  of alternatives, FFmpeg still includes SMB support

Build with SMB option ON fails.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-11-23 04:12:24 UTC 
A commit references this bug:

Author: jbeich
Date: Mon Nov 23 04:11:59 UTC 2020
New revision: 556085
URL: https://svnweb.freebsd.org/changeset/ports/556085

Log:
  multimedia/mpv: drop SMB option after r556071

  waf-light: error: no such option: --enable-libsmbclient
  https://github.com/mpv-player/mpv/commit/3b8b7cb9d481

  PR:		251318
  Submitted by:	VVD <vvd@unislabs.com>

Changes:
  head/multimedia/mpv/Makefile