Bug 251341

Summary: security/py-fail2ban: Update to 0.11.2
Product: Ports & Packages Reporter: theis
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Some People CC: madpilot, theis
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
theis: maintainer-approval+
Poudriere build log
none
New patch theis: maintainer-approval+

Description theis 2020-11-24 10:36:06 UTC
Created attachment 219919 [details]
patch

Upgrade security/py-fail2ban to version 0.11.2
Comment 1 Guido Falsi freebsd_committer 2020-11-24 12:16:58 UTC
Created attachment 219922 [details]
Poudriere build log

Hi,

I am testing this in poudriere and it reports a problem with the plist.

The software installs a bunch of files in "%%PYTHON_SITELIBDIR%%/fail2ban/tests".

These are not included in the plist. If they are part of the standard installation they should be added there.

They should be included in the plist if required. If not is there a flag in fail2ban which prevents these from being generated/installed?

As a last resort, if these files are not needed in user installations you could remove them from STAGEDIR with a command in the post-install target, but this is not the best solution.

I'm attaching the build log so you can see the problem.
Comment 2 Guido Falsi freebsd_committer 2020-11-24 12:29:47 UTC
Oh, I noticed, looks like the option to disable test file installation has changed to "--without-tests" (note the extra "s").

I'm now changing that and testing again.
Comment 3 Guido Falsi freebsd_committer 2020-11-24 13:19:04 UTC
(In reply to Guido Falsi from comment #2)

Ok not so easy, looks like that option is honored only if passed with the build option.
Comment 4 theis 2020-11-24 13:27:19 UTC
I'll have a look.

It's strange, I haven't change the build itself, and tests were always part of the source but not of the FreeBSD port.
Comment 5 Guido Falsi freebsd_committer 2020-11-24 13:38:10 UTC
Created attachment 219924 [details]
New patch

I've created a patch which installs without errors/warnings.

Does this look correct to you?
Comment 6 theis 2020-11-24 13:43:04 UTC
Yes!
Thank you very much
Comment 7 commit-hook freebsd_committer 2020-11-24 21:21:45 UTC
A commit references this bug:

Author: madpilot
Date: Tue Nov 24 21:21:00 UTC 2020
New revision: 556221
URL: https://svnweb.freebsd.org/changeset/ports/556221

Log:
  - Update fail2ban to 0.11.2
  - Remove patches now included in the upstream code
  - Adapt option to not install test files

  PR:		251341
  Submitted by:	theis@gmx.at (maintainer)

Changes:
  head/security/py-fail2ban/Makefile
  head/security/py-fail2ban/distinfo
Comment 8 Guido Falsi freebsd_committer 2020-11-24 21:22:20 UTC
Committed. Thanks!