Bug 251356

Summary: www/firefox: build failure after upgrading lang/rust (r556157)
Product: Ports & Packages Reporter: Barbara Guida <bar>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: gecko, mikael, rust, vvd
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Barbara Guida freebsd_committer 2020-11-24 22:48:57 UTC
After upgrading lang/rust and devel/rust-cbindgen from r556157 on 12.2-STABLE, I'm trying to upgrade www/firefox but I'm getting the following error:

Running `CARGO=/usr/local/bin/cargo CARGO_CRATE_NAME=libloading CARGO_MANIFEST_DIR=/usr/ports/www/firefox/work/firefox-83.0/third_party/rust/libloading CARGO_PKG_AUTHORS='Simonas Kazlauskas <libloading@kazlauskas.me>' CARGO_PKG_DESCRIPTION='A safer binding to platform’s dynamic library loading utilities' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=ISC CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=libloading CARGO_PKG_REPOSITORY='https://github.com/nagisa/rust_libloading/' CARGO_PKG_VERSION=0.6.2 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=6 CARGO_PKG_VERSION_PATCH=2 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/usr/ports/www/firefox/work/.build/release/deps:/usr/local/lib' OUT_DIR=/usr/ports/www/firefox/work/.build/x86_64-unknown-freebsd/release/build/libloading-5a97b9f65dab7c27/out /usr/local/bin/rustc --crate-name libloading /usr/ports/www/firefox/work/firefox-83.0/third_party/rust/libloading/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no -C metadata=953ee19b08b9b3db -C extra-filename=-953ee19b08b9b3db --out-dir /usr/ports/www/firefox/work/.build/x86_64-unknown-freebsd/release/deps --target x86_64-unknown-freebsd -C linker=/usr/ports/www/firefox/work/firefox-83.0/build/cargo-linker -L dependency=/usr/ports/www/firefox/work/.build/x86_64-unknown-freebsd/release/deps -L dependency=/usr/ports/www/firefox/work/.build/release/deps --cap-lints warn -C opt-level=2 -C force-frame-pointers=yes --cap-lints warn -C target-cpu=skylake -Cembed-bitcode=yes -C codegen-units=1 -l c`
error[E0432]: unresolved import `crate::arch::x86_64::_mm_shuffle_pi8`
   --> /usr/ports/www/firefox/work/firefox-83.0/third_party/rust/packed_simd/src/codegen/shuffle1_dyn.rs:40:29
    |
40  |                         use crate::arch::x86_64::_mm_shuffle_pi8;
    |                             ^^^^^^^^^^^^^^^^^^^^^---------------
    |                             |                    |
    |                             |                    help: a similar name exists in the module: `_mm_shuffle_epi8`
    |                             no `_mm_shuffle_pi8` in `arch::x86_64`
...
297 | impl_shuffle1_dyn!(u8x8);
    | ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

I guess that also mail/thunderbird upgrade is failing for the same problem.
Comment 1 Jan Beich freebsd_committer 2020-11-25 00:10:33 UTC
(In reply to Barbara Guida from comment #0)
> -C target-cpu=skylake

Did you define CPUTYPE?=skylake via make.conf(5)? If not provide complete build log, preferably from poudriere as it collects all the bits necessary to reproduce.
Comment 2 commit-hook freebsd_committer 2020-11-25 02:57:25 UTC
A commit references this bug:

Author: jbeich
Date: Wed Nov 25 02:56:38 UTC 2020
New revision: 556251
URL: https://svnweb.freebsd.org/changeset/ports/556251

Log:
  gecko: apply the rest of the upstream fix for rust 1.48

  PR:		251356

Changes:
  head/mail/thunderbird/files/patch-bug1667736
  head/www/firefox/files/patch-bug1667736
  head/www/firefox-esr/files/patch-bug1667736
Comment 3 VVD 2020-11-25 03:13:03 UTC
(In reply to commit-hook from comment #2)
Does lang/spidermonkey78 need this patch too?
Comment 4 Jan Beich freebsd_committer 2020-11-25 03:18:39 UTC
No clue. gecko@ doesn't maintain lang/spidermonkey*. I'm also waiting for confirmation ports r556251 (comment 2) actually helps.
Comment 5 Barbara Guida freebsd_committer 2020-11-25 05:02:57 UTC
(In reply to Jan Beich from comment #1)
Oh yes, my bad. Anyway I'm trying to rebuild it after r556251 before reverting, let me know if a feedback is needed.
Comment 6 Barbara Guida freebsd_committer 2020-11-25 05:03:31 UTC
(In reply to VVD from comment #3)
No, I had no problem with lang/spidermonkey78.
Comment 7 Barbara Guida freebsd_committer 2020-11-25 06:16:37 UTC
(In reply to Jan Beich from comment #4)
Yes, that commit fixed the build.
Comment 8 Barbara Guida freebsd_committer 2020-11-25 06:19:41 UTC
(In reply to Barbara Guida from comment #7)
For both www/firefox and mail/thunderbird.
Comment 9 Mikael Urankar freebsd_committer 2020-11-25 07:27:55 UTC
(In reply to commit-hook from comment #2)
Thank you!