Bug 251465

Summary:	devel/bmake fails unit tests in build
Product:	Ports & Packages	Reporter:	mjl
Component:	Individual Port(s)	Assignee:	Mikolaj Golub <trociny>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	0mp
Priority:	---	Flags:	bugzilla: maintainer-feedback? (trociny)
Version:	Latest
Hardware:	i386
OS:	Any

Description mjl 2020-11-29 20:11:25 UTC

During ports build on FreeBSD 12.2 i386

#      test  varparse-dynamic
#      test  varparse-errors
#      test  varparse-mod
#      test  varparse-undef-partial
#      test  varquote
--- /usr/ports/devel/bmake/work/bmake/unit-tests/varmod-gmtime.exp      2020-11-01 11:57:02.000000000 +1300
+++ varmod-gmtime.out   2020-11-30 09:10:11.540801000 +1300
@@ -17,7 +17,7 @@
 : 0 becomes ok.
 : 1 becomes Thu Jan  1 00:00:01 1970.
 : INT32_MAX becomes Tue Jan 19 03:14:07 2038.
-: INT32_MAX + 1 becomes Tue Jan 19 03:14:08 2038.
+: INT32_MAX + 1 becomes Fri Dec 13 20:45:52 1901.
 make: Invalid time value: 10000000000000000000000000000000}.
 
 : overflow becomes mtime=10000000000000000000000000000000}.
--- /usr/ports/devel/bmake/work/bmake/unit-tests/varmod-localtime.exp   2020-11-01 11:57:02.000000000 +1300
+++ varmod-localtime.out        2020-11-30 09:10:11.953868000 +1300
@@ -17,7 +17,7 @@
 : 0 becomes ok.
 : 1 becomes Thu Jan  1 01:00:01 1970.
 : INT32_MAX becomes Tue Jan 19 04:14:07 2038.
-: INT32_MAX + 1 becomes Tue Jan 19 04:14:08 2038.
+: INT32_MAX + 1 becomes Fri Dec 13 21:45:52 1901.
 make: Invalid time value: 10000000000000000000000000000000}.
 
 : overflow becomes ocaltime=10000000000000000000000000000000}.
Failed tests: varmod-gmtime varmod-localtime
*** Error code 1

Stop.
bmake[2]: stopped in /usr/ports/devel/bmake/work/bmake/unit-tests
*** Error code 1

Stop.
bmake[1]: stopped in /usr/ports/devel/bmake/work/bmake
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/bmake

Comment 1 Mikolaj Golub freebsd_committer

2020-11-30 17:12:44 UTC

I could update files/patch-unit-tests_Makefile to disable varmod-gmtime test. But a new version of bmake with the fix is going to be released soon and I am planning to update the port, so I am not sure the patch is worth committing.

Comment 2 commit-hook freebsd_committer

2020-12-02 19:21:25 UTC

A commit references this bug:

Author: trociny
Date: Wed Dec  2 19:20:35 UTC 2020
New revision: 556848
URL: https://svnweb.freebsd.org/changeset/ports/556848

Log:
  update to 20201124

  Also disable varmod-gmtime and varmod-localtime tests which are
  currently fail on i386

  PR:		251465

Changes:
  head/devel/bmake/Makefile
  head/devel/bmake/distinfo
  head/devel/bmake/files/patch-unit-tests_Makefile

Comment 3 Mateusz Piotrowski freebsd_committer

2023-02-18 18:45:46 UTC

(In reply to Mikolaj Golub from comment #1)
According to this comment, newer version of bmake contain the fix for the reported issue. As it is a problem report from 2020 I assume it is safe to close it.