Summary: | archivers/libarchive: add mbedTLS support and remove LZO default | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Martin Matuska <mm> | ||||||
Component: | Individual Port(s) | Assignee: | Greg Lewis <glewis> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Many People | CC: | diizzy, fluffy | ||||||
Priority: | --- | Flags: | glewis:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Created attachment 220124 [details]
Updated patch
Fixed typo in CRYPTO_DESC
libarchive is at 3.5.0 and this change looks reasonable as far as I can tell I'm ok with the crypto changes. I don't understand the LZO change. We distribute a lot of GPL 2 packages, how is this any different? If we distribute an LZO package then I don't see how a package that links to the library from it is somehow a violation where the LZO distribution is not. The main difference is that LZO is GPL and not LGPL. You cannot distribute software linked to a GPL-licensed library under a different license than GPL. Good point. Approved. A commit references this bug: Author: fluffy Date: Tue Jan 5 16:59:45 UTC 2021 New revision: 560412 URL: https://svnweb.freebsd.org/changeset/ports/560412 Log: archivers/libarchive: add mbedTLS support and remove LZO default PR: 251496 Submitted by: mm Approved by: maintainer (glewis) Changes: head/archivers/libarchive/Makefile committed |
Created attachment 220122 [details] libarchive patch Libarchive supports crypto and hashing via OpenSSL, Nettle or mbedTLS. Add a RADIO option to select one or none of these. If none is selected, system libmd is used for hashing and crypto support is not built-in. Distributing libarchive with LZO bindings violates LZO's GPL license. Remove LZO from OPTIONS_DEFAULT.