Bug 251574
| Summary: | [NEW PORT] games/sowon: Graphical countdown timer application | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Nico Sonack <nsonack> | ||||||
| Component: | Individual Port(s) | Assignee: | Max Brazhnikov <makc> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | diizzy, makc | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Quick review, Where's the reference to 1.0.0? Example 5.13. is probably what you're looking for in Porter's handbook. Remove MASTER_SITES https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description Games seems a bit odd as category, deskutils seems like a better choice? Does it pass portlint? https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#testing-portlint Is port tested using Poudriere? Best regards, Daniel (In reply to daniel.engberg.lists from comment #1) > Where's the reference to 1.0.0? > Example 5.13. is probably what you're looking for in Porter's handbook. Thank you for the reference to the Porter's handbook. Indeed I haven't seen that example. On the 1.0.0 version number: That was decided upon in a private conversation. Since that is not official, I agree on changing it to the commit date. > Games seems a bit odd as category, deskutils seems like a better choice? Yes. It definitely is. > Does it pass portlint? Yes. I specifically tested it against portlint. > Is port tested using Poudriere? No. I am going do that. Thank you for the review. I'm gonna fix the issues you've mentioned and update the patch. Best regards, Nico Created attachment 220304 [details]
Patch with requested changes
- Tested with poudriere (12.2 RELEASE amd64)
- Checked against portlint -A and portfmt
Compile tested on FreeBSD 13.0-CURRENT #0 r367711 (amd64) A commit references this bug: Author: makc Date: Thu Dec 17 21:03:16 UTC 2020 New revision: 558328 URL: https://svnweb.freebsd.org/changeset/ports/558328 Log: Add new port deskutils/sowon: Graphical countdown and timer application. PR: 251574 Submitted by: Nico Sonack Changes: head/deskutils/Makefile head/deskutils/sowon/ head/deskutils/sowon/Makefile head/deskutils/sowon/distinfo head/deskutils/sowon/pkg-descr thanks! |
Created attachment 220237 [details] Patchfile for the port