Bug 251598
| Summary: | games/tali: Update to 3.38.2 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Neel Chauhan <nc> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | diizzy, tcberner, vishwin | ||||||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
This looks incorrect USES= gmake meson pathfix Best regards, Daniel The truth is that newer GNOME packages use Meson as their build system instead of GNU autotools, hence why it's there. This is done in other GNOME Games: neel@omen:/usr/ports/games % grep -R meson gnome* gnome-2048/Makefile:USES= gettext gl gmake gnome localbase meson pathfix pkgconfig tar:xz xorg gnome-chess/Makefile:USES= desktop-file-utils gettext gl gnome localbase meson \ gnome-klotski/Makefile:USES= gettext gmake gnome localbase meson pathfix \ gnome-mahjongg/Makefile:USES= gettext gmake gnome localbase meson pathfix pkgconfig tar:xz gnome-mines/Makefile:USES= gettext gnome localbase meson pkgconfig python:3.6+,build tar:xz gnome-nibbles/Makefile:USES= gettext gl gnome meson pathfix \ gnome-robots/Makefile:USES= gettext gmake gnome localbase meson pathfix \ gnome-sudoku/Makefile:USES= compiler:c++11-lang gettext gmake gnome meson \ gnome-taquin/Makefile:USES= gettext gmake gnome localbase meson pathfix pkgconfig tar:xz xorg gnome-tetravex/Makefile:USES= gettext gmake gnome localbase meson pathfix pkgconfig \ neel@omen:/usr/ports/games % The USES=gmake is wrong here, since meson calls ninja to drive the build in this (and at least nearly every other) case. It may not have any effect when USES=meson is also present but it is extra and unnecessary. Created attachment 220298 [details]
Patch (Revision 2)
You're right. I removed USES=gmake and it passed Poudriere. Thanks!
...and is pathfix needed? Created attachment 220323 [details]
Patch (Revision 3)
You're right too, here's an updated patch.
Committed, thanks. A commit references this bug: Author: tcberner Date: Thu Dec 10 17:57:44 UTC 2020 New revision: 557449 URL: https://svnweb.freebsd.org/changeset/ports/557449 Log: games/tali: Update to 3.38.2 PR: 251598 Submitted by: Neel Chauhan <neel@neelc.org> Changes: head/games/tali/Makefile head/games/tali/distinfo head/games/tali/pkg-plist |
Created attachment 220272 [details] Patch (Revision 1) Passes poudriere.