| Summary: | mips/mediatek: Kernel fails to build on Mediatek MT7628: error: use of undeclared identifier 'cpu_model' | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Priit Trees <trees> | ||||
| Component: | kern | Assignee: | Bugmeister <bugmeister> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Some People | CC: | jhb, koobs | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | CURRENT | ||||||
| Hardware: | mips | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
On the surface these changes look ok to me. @John Is this OBE now with mips removal, or is there something we can do with the attached patch relevent in other components, or for other archs? ^Triage: close as Overcome By Events. I'm sorry this PR never got looked at. In the meantime, FreeBSD has dropped MIPS support, so there is nothing to do here. |
Created attachment 220290 [details] My patch for medatek mt76x8 I compile Medaitek MT7688 kernel. I get three errors. First error: /src/sys/mips/mediatek/mtk_soc.c:415:3: error: use of undeclared identifier 'cpu_model' cpu_model[idx] = chipid0_3[idx]; ^ /src/sys/mips/mediatek/mtk_soc.c:416:3: error: use of undeclared identifier 'cpu_model' cpu_model[idx + offset] = chipid4_7[idx]; ^ /src/sys/mips/mediatek/mtk_soc.c:420:2: error: use of undeclared identifier 'cpu_model' cpu_model[2 * offset] = 0; ^ Second error: /src/sys/mips/mediatek/mtk_clock.c:126:39: error: variable 'mask' is uninitialized when used here [-Werror,-Wuninitialized] if (mtk_sysctl_get(SYSCTL_CLKCFG1) & mask) ^~~~ /src/sys/mips/mediatek/mtk_clock.c:121:15: note: initialize the variable 'mask' to silence this warning uint32_t mask; ^ = 0 Third error: /src/sys/dev/rt/if_rt.c:315:54: error: cast from 'char **' to 'const char **' must have all intermediate pointers const qualified to be safe [-Werror,-Wcast-qual] device_get_unit(dev), "macaddr", (const char **)&var)) { ^ I patch the problems for me. Can somebody look the patch over and add it or make better solution.