Bug 251677
| Summary: | finance/quickfix drop python2 support | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | m.tsatsenko | ||||||||
| Component: | Individual Port(s) | Assignee: | Rene Ladan <rene> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | rene, swills | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249685 | ||||||||||
| Attachments: |
|
||||||||||
It fails to build here on 12.2-amd64 with PYTHON off, see https://people.freebsd.org/~rene/stuff/quickfix-1.15.1.log (In reply to Rene Ladan from comment #1) Ah, I think this is because the CONFIGURE_ARGS line to disable Python gets removed in this patch. (In reply to Rene Ladan from comment #2) Nope (and that line was indeed wrong), but adding "python" to PYTHON_CONFIGURE_WITH does not help either. Created attachment 221256 [details]
updated patch
Bring back accidentally removed CONFIGURE_ARGS line
(In reply to m.tsatsenko from comment #4) That line was wrong to begin with, see example 5.40 of https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html for background. The --without-python option is unknown to configure and --without-python3 is correctly handled by the PYTHON_CONFIGURE_WITH helper. The problem is that somehow configure outputs the wrong Makefile. Right. It should be --without-python2. Regarding --without-python3. PYTHON_CONFIGURE_WITH somehow doenst work properly in poudrierre. Works fine in a live system though. It is passed to the configure, but for some reason doesnt seem to have any effect. I guess that was the reason why I added --without-python3 in the first place. And honestly I don't see any real point in wasting more time trying to make it build. It does not work anyway: any python script I tried to run segfaults at start. Therefore I suggest to remove python support altogether. (In reply to m.tsatsenko from comment #7) Yeah, I was perhaps getting a bit academical. But if it doesn't work anyway it is probably indeed better to just remove it. I think I figured it out and managed to make it build successfully with both PYHON enabled and disabled. Will update the patch shortly Created attachment 221479 [details]
fixed (hopefully) patch
This version builds fine with both PYTHON enabled and disabled (poudrierre 122amd64)
Your latest patch indeed builds fine, I committed it. A commit references this bug: Author: rene Date: Tue Jan 12 20:50:24 UTC 2021 New revision: 561379 URL: https://svnweb.freebsd.org/changeset/ports/561379 Log: finance/quickfix: migrate to Python 3 PR: 251677 [1] PR: 249685 [2] Submitted by: maintainer [1] Submitted by: swills [1] Changes: head/finance/quickfix/Makefile head/finance/quickfix/files/patch-m4_ax__python.m4 |
Created attachment 220362 [details] patch - Switch python version from 2.7 to 3.7 QA: poudriere 122amd64 - OK portlint - no errors