Bug 251718

Summary: science/py-scipy: Update 1.2.2 -> 1.5.4
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: thierry
Priority: --- Flags: bugzilla: maintainer-feedback? (python)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246364
Attachments:
Description Flags
patch none

Description Yuri Victorovich freebsd_committer freebsd_triage 2020-12-10 02:47:37 UTC
Created attachment 220417 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2020-12-23 23:37:54 UTC
Committed.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-12-23 23:39:29 UTC
A commit references this bug:

Author: yuri
Date: Wed Dec 23 23:38:29 UTC 2020
New revision: 559036
URL: https://svnweb.freebsd.org/changeset/ports/559036

Log:
  science/py-scipy: Update 1.2.2 -> 1.5.4

  PR:		251718
  Approved by:	python (maintainer's timeout; 14 days)

Changes:
  head/science/py-scipy/Makefile
  head/science/py-scipy/distinfo
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2020-12-24 09:27:56 UTC
Yuri, with this patch, this port depends both on libblas.so:math/blas and on 
libopenblas.so:math/openblas:

-BUILD_DEPENDS= ${PYNUMPY}
+BUILD_DEPENDS= ${PYNUMPY} \
+               ${PYTHON_PKGNAMEPREFIX}pip>0:devel/py-pip@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}pybind11>0:devel/py-pybind11@${PY_FLAVO
R}
+LIB_DEPENDS=   libblas.so:math/blas
 RUN_DEPENDS=   ${PYNUMPY}

-USES=          fortran python shebangfix
+USES=          blaslapack:openblas fortran python shebangfix

Do you really want that?

I guess that you should remove the line
LIB_DEPENDS=   libblas.so:math/blas
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2020-12-25 05:37:28 UTC
(In reply to Thierry Thomas from comment #3)

Hi Thierry,

Both  LIB_DEPENDS=libblas.so:math/blas and USES=blaslapack:openblas were added in r559036, which is a redundancy, you are right.

However, it doesn't build without libblas.so:math/blas, but builds without blaslapack:openblas, so I am removing the latter instead.

Thanks for letting me know.

Yuri
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-12-25 05:42:22 UTC
A commit references this bug:

Author: yuri
Date: Fri Dec 25 05:41:53 UTC 2020
New revision: 559210
URL: https://svnweb.freebsd.org/changeset/ports/559210

Log:
  science/py-scipy: Remove the recently added USES=blaslapack:openblas because LIB_DEPENDS=libblas.so:math/blas provides blas

  It does build with libblas.so:math/blas, but doesn't with blaslapack:openblas.

  PR:		251718
  Reported by:	thierry
  Approved by:	python (correction of the previous recent commit r559036)

Changes:
  head/science/py-scipy/Makefile