Bug 251721

Summary: devel/glibmm: Update to 2.68.0
Product: Ports & Packages Reporter: Neel Chauhan <nc>
Component: Individual Port(s)Assignee: freebsd-gnome (Nobody) <gnome>
Status: Closed Not Accepted    
Severity: Affects Many People CC: diizzy, nc
Priority: --- Flags: bugzilla: maintainer-feedback? (gnome)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 252333    
Bug Blocks: 251909    
Attachments:
Description Flags
Patch (Revision 1)
none
Patch (Revision 2)
none
Patch (Revision 1) for Version 2.68.0 none

Description Neel Chauhan freebsd_committer freebsd_triage 2020-12-10 05:31:55 UTC
Created attachment 220420 [details]
Patch (Revision 1)

Passes poudriere.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2020-12-10 10:44:49 UTC
Are gmake and libtool really required?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2020-12-10 10:50:42 UTC
..being a bit quick on the send button, sorry!

pathfix is probably not needed either

build-documentation and build-examples should be made into port/menu options

USES= should be merged into one variable

INSTALL_TARGET= can also most likely be dropped too

It would also be nice if make test (test-target) worked for regression testing.

Best regads,
Daniel
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2020-12-11 03:41:52 UTC
Created attachment 220446 [details]
Patch (Revision 2)

Thanks for your feedback! Here's an updated patch.
Comment 4 Neel Chauhan freebsd_committer freebsd_triage 2021-01-01 18:04:37 UTC
Created attachment 221169 [details]
Patch (Revision 1) for Version 2.68.0

New version 2.68.0.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2021-01-01 20:21:32 UTC
You need to start with creating a port for libsigc++30 (it doesn't exist and use meson), connect it to Mk/Uses/gnome.mk and lastly use it in the Makefile.

PORTVERSION --> DISTVERSION
Merge (combine) USES into one variable and remove "+" --> USES= .....
Convert to Meson (preferably)

Thanks for your work on this :-)
Comment 6 Neel Chauhan freebsd_committer freebsd_triage 2021-01-01 22:00:40 UTC
No problem.

Right now, I am unable to make accessibility/atkmm see a dependency so I closed this, to prevent an broken update from being committed.

I will re-open once I can get it working.