Bug 251830
| Summary: | handbook: obsolete samba port or package reference | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Documentation | Reporter: | George Guimaraes <george.guimaraes> | ||||
| Component: | Books & Articles | Assignee: | Guangyuan Yang <ygy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | george.guimaraes, ygy | ||||
| Priority: | --- | Keywords: | easy, patch-ready | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/network-samba.html | ||||||
| Attachments: |
|
||||||
|
Description
George Guimaraes
2020-12-14 03:08:49 UTC
(In reply to George Guimaraes from comment #0) Thank you for your interest! You can just use the "Add an attachment" above to attach a diff if you have a patch to submit, or even better, submit to https://reviews.freebsd.org and reference it back here. We would love to review and commit the change ;) Confirmed the docs are referring to EOL version of samba (https://wiki.samba.org/index.php/Samba_Release_Planning). I am updating it with the current supported version as soon as I can. (In reply to George Guimaraes from comment #2) Thanks, if you want to submit a patch, I can help bring it in ;) Created attachment 220763 [details] Fixes 251830 Please review the patch attached. I know there are several pre-existing formatting issues in the file I changed, but I wanted to keep the patch straight to the point. I tried to register on https://reviews.freebsd.org/source/doc/ to submit the patch from there but for some reason I'm not getting the e-mail for confirmation. Thank you, -George. Comment on attachment 220763 [details]
Fixes 251830
I realize the change was for the English version only, even though it applies to all languages. What is the process of updating this kind of information? I wonder if there isn't support to create a macro somewhere that can be used to track port/pkg version. If this is something supported by the current markup solution I would be glad to work on it.
(In reply to George Guimaraes from comment #5) Thanks for the patch! For i10n, each language team sync the updates from the en_US version, and update their translation respectively - which will have a delay - though in all cases, we only need to worry about the en_US version. (In reply to George Guimaraes from comment #4) Please contact phabric-admin@freebsd.org for your reviews.freebsd.org registration errors encountered. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/doc/commit/?id=b62d4babfdbd3d9dc393c378bf6960b9d0781ada commit b62d4babfdbd3d9dc393c378bf6960b9d0781ada Author: Guangyuan Yang <ygy@FreeBSD.org> AuthorDate: 2020-12-23 17:17:49 +0000 Commit: Guangyuan Yang <ygy@FreeBSD.org> CommitDate: 2020-12-23 17:30:15 +0000 Update obsolete samba port references PR: 251830 Submitted by: George Guimaraes <george.guimaraes@outlook.com> en_US.ISO8859-1/articles/cups/article.xml | 2 +- en_US.ISO8859-1/books/handbook/network-servers/chapter.xml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (In reply to George Guimaraes from comment #5) Committed with changes, thanks! I noticed that you also proposed to add a section about /etc/fstab and samba mounts - if you have more patches to submit, feel free to open a new PR with it. ;) Thanks for taking the patch. I didn't see it and created a Review in Phabricator (https://reviews.freebsd.org/D27745). Please ignore that. Another thing I was thinking is how we need to phase out the EOL package in the repository catalogue. I tried to contact the current maintainer via e-mail but didn't get any replies. Any advise on how to get involved with that? Thanks! (In reply to George Guimaraes from comment #10) I myself am not a ports expert, so I would suggest that you use relevant mailing lists and/or IRC channels [1] to ask the question. [1]: https://wiki.freebsd.org/IRC/Channels |
