Bug 251991
| Summary: | x11-themes/nordic-theme: Improve Makefile | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alexander Vereeken <Alexander88207> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | fernape | ||||||||
| Priority: | --- | Keywords: | easy, patch-ready | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Q/A: Makefile: [46]: whitespace before end of line. Q/A: Some variables are out of place: # Options definitions OPTIONS_DEFINE OPTIONS_DEFAULT OPTIONS_SUB # Options descriptions CINNAMON_DESC -CINNAMON_BROKEN -CINNAMON_IMPLIES -CINNAMON_VARS GNOMESHELL_DESC -GNOMESHELL_VARS KDE_DESC METACITY_DESC -METACITY_VARS XFCE_DESC # Options helpers +CINNAMON_IMPLIES +CINNAMON_BROKEN +CINNAMON_VARS +GNOMESHELL_VARS +METACITY_VARS XFCE_VARS See https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-order-options Otherwise, good job improving the Makefile! Created attachment 221300 [details]
nordic-theme-update(v2).diff
Hello Fernando,
thanks for looking over. Everything should be in order now :)
(In reply to Alexander Vereeken from comment #2) Excellent, thanks! Created attachment 221367 [details]
nordic-theme-update(v3).diff
While here, also include a list of supported desktop environments to pkg-descr.
A commit references this bug: Author: fernape Date: Fri Jan 8 16:56:54 UTC 2021 New revision: 560795 URL: https://svnweb.freebsd.org/changeset/ports/560795 Log: x11-themes/nordic-theme: Improve Makefile Related to changes in r558332. Also, add information about supported DEs in pkg-descr. PR: 251991 Submitted by: Alexander88207@protonmail.com (maintainer) Changes: head/x11-themes/nordic-theme/Makefile head/x11-themes/nordic-theme/pkg-descr Committed, Thanks! |
Created attachment 220753 [details] nordic-theme-update.diff When the ant-dracula-theme was added, the Makefile was improved by makc (r558332). I like to use the improvements here as well :)