Bug 252117

Summary: devel/py-llfuse: Update to 1.3.8
Product: Ports & Packages Reporter: John Hein <jcfyecrayz>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Some People CC: python, swills, yuri
Priority: --- Keywords: needs-qa
Version: LatestFlags: koobs: merge-quarterly?
Hardware: Any   
OS: Any   
See Also: https://github.com/python-llfuse/python-llfuse/issues/24
Attachments:
Description Flags
[patch] update py-llfuse to 1.3.8 jcfyecrayz: maintainer-approval?

Description John Hein 2020-12-24 21:44:56 UTC
Created attachment 220901 [details]
[patch] update py-llfuse to 1.3.8

1.3.8 was released in October, 2020.

It supports python3.9 - 1.3.6 fails at build time with python3.9.  See the upstream report regarding that issue:

https://github.com/python-llfuse/python-llfuse/issues/24

Differences from Changes.rst:

Release 1.3.8 (2020-10-10)
==========================

* fix compilation on FreeBSD, #28
* export DEVELOPER_MODE=1 can be used to opt in (default is 0), #22
* twine-based pypi-uploading, Qubes OS support for GPG signing,
  see util/sdist-sign and pypi-upload

Release 1.3.7 (2020-10-04)
==========================

* Rebuild with Cython 0.29.21 for Python 3.9 compatibility.


QA:
 - poudriere testport (ok, including testing with python37 & python39)
 - portlint (ok)
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2020-12-24 21:44:56 UTC
Maintainer informed via mail
Comment 2 John Hein 2020-12-24 21:48:01 UTC
By the way, the patch also changes the RUN_DEPENDS on py-contextlib2 to be only for python2.7 - it's not used for python3.x
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2021-01-31 05:51:27 UTC
Committed with changes, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-01-31 05:51:37 UTC
A commit references this bug:

Author: yuri
Date: Sun Jan 31 05:51:23 UTC 2021
New revision: 563465
URL: https://svnweb.freebsd.org/changeset/ports/563465

Log:
  devel/py-llfuse: Update 1.3.6 -> 1.3.8

  PR:		252117
  Submitted by:	jcfyecrayz@liamekaens.com
  Approved by:	stdin@niklaas.eu (maintainer's timeout 30 days)

Changes:
  head/devel/py-llfuse/Makefile
  head/devel/py-llfuse/distinfo
Comment 5 John Hein 2021-02-01 19:24:31 UTC
(In reply to commit-hook from comment #4)
Thanks.  Could you also remove the dependency on py-contextlib2?  That is only needed for python2.7
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2021-02-01 19:37:45 UTC
(In reply to John Hein from comment #5)

This library does support python-2.7 according to its setup.py
Comment 7 Steve Wills freebsd_committer freebsd_triage 2021-02-01 20:23:07 UTC
(In reply to Yuri Victorovich from comment #6)
That doesn't mean ports should require Python 2.7.
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2021-02-01 20:36:36 UTC
(In reply to Steve Wills from comment #7)

> That doesn't mean ports should require Python 2.7.

This doesn't make the port to require Python 2.7.
Comment 9 John Hein 2021-02-01 21:13:06 UTC
(In reply to Yuri Victorovich from comment #6)
Currently, the port is limited to 3.6+.

If you change to USES=python, then I agree, having it depend on py-contextlib2 would be correct, but it should only depend on py-contextlib2 for PY_FLAVOR=py27 (as in the original patch).

This all seems like a very short term nuance, however.  How long is python27 going to be in the ports tree?  Assuming the answer is 'not very long', we might as well leave it at python 3.6+ and remove the py-contextlib2 dep.
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2021-02-01 21:21:23 UTC
(In reply to John Hein from comment #9)

It's a small nuance.

The port can get limited to python:3.6+ for 2 reasons:
1. When it doesn't build with python-2.7
2. When some dependency is broken or incompatible with python-2.7

In this case 2. is the true. If/once this dependency is fixed someone would just change python:3.6+ -> python in devel/py-llfuse.

And this port would be left broken for python-2.7. Yes, it's best to look and retest when doing this, but the reality is different and often people don't retest.

This is my rationale for this line.

On the other side, what is the downside? There's really none, it's just a line. It doesn't force python-2.7 or change the behavior in any way.
Comment 11 John Hein 2021-02-01 21:35:22 UTC
(In reply to Yuri Victorovich from comment #10)
The downside is an unnecessary dependency.

As I understand the additon of 3.6+, it was done because python27 is going away.  As long as the 3.6+ is there, the dependency shouldn't be there.  If someone then removes the 3.6+ without testing their change, then that's their fault.

But I don't care that much.  We're definitely quibbling about some minor issues.

I understand your take that you want to leave it there just in case someone changes to USES=python (even for the short time python27 is still available in the ports tree).
Comment 12 Yuri Victorovich freebsd_committer freebsd_triage 2021-02-01 21:49:03 UTC
(In reply to John Hein from comment #11)

> The downside is an unnecessary dependency.

What dependency? This command shows that devel/py-setuptools is the only dependency:

> $ cd /usr/ports/devel/py-llfuse && make -V RUN_DEPENDS
> py37-setuptools>0:devel/py-setuptools@py37 /usr/local/bin/python3.7:lang/python37

Is there a command that shows that there are other dependencies?
Comment 13 John Hein 2021-02-02 20:41:27 UTC
(In reply to Yuri Victorovich from comment #12)
Apologies. I completely missed the py27_ in front of RUN_DEPENDS in your commit.  So there's no extra dependency.

So the only downside is cognitive dissonance from seeing USES=python:3.6+ with a py27_* helper.  Definitely not that big of a deal.  I withdraw my misguided suggestion in comment 5.