Bug 252233

Summary: mail/rainloop-community: missing (optional) dependency
Product: Ports & Packages Reporter: Max Christian <accounts>
Component: Individual Port(s)Assignee: Koichiro Iwao <meta>
Status: Closed FIXED    
Severity: Affects Many People CC: meta, yasu
Priority: --- Flags: bugzilla: maintainer-feedback? (yasu)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch file yasu: maintainer-approval+

Description Max Christian 2020-12-28 13:49:05 UTC 
I would like to suggest to add PHP `simplexml` as dependency for rainloop, because rainloop requires it for its contacts sync feature via a CardDav server and for me this is a must-have feature.

The feature has to be enabled in the `admin panel` under `contacts` and is called `Allow contacts sync (with external CardDAV server) and must then be configured in the web interface of the individual users under `settings` -> `contacts` -> `Remote Synchronization (CardDAV)

But configuring it currently triggers a meaningless error message `Contacts synchronization error` if the `php-simplexml` is not installed (the browsers javascript console has more info).
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2020-12-28 18:38:12 UTC 
Created attachment 221055 [details]
Patch file

Add missing dependency to simplexml。
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-01-04 08:45:26 UTC 
A commit references this bug:

Author: meta
Date: Mon Jan  4 08:45:07 UTC 2021
New revision: 560266
URL: https://svnweb.freebsd.org/changeset/ports/560266

Log:
  mail/rainloop: add missing dependency on simplexml

  PR:		252233
  Submitted by:	Yasuhiro Kimura <yasu@utahime.org> (maintainer)
  Reported by:	Max Christian <accounts@wireme.de>
  Sponsored by:	HAW International

Changes:
  head/mail/rainloop/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-01-04 08:47:27 UTC 
A commit references this bug:

Author: meta
Date: Mon Jan  4 08:46:46 UTC 2021
New revision: 560267
URL: https://svnweb.freebsd.org/changeset/ports/560267

Log:
  MFH: r560266

  mail/rainloop: add missing dependency on simplexml

  PR:		252233
  Submitted by:	Yasuhiro Kimura <yasu@utahime.org> (maintainer)
  Reported by:	Max Christian <accounts@wireme.de>
  Sponsored by:	HAW International

Changes:
_U  branches/2021Q1/
  branches/2021Q1/mail/rainloop/Makefile
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2021-01-04 08:48:39 UTC 
Committed, thanks!