Bug 252456
| Summary: | archivers/libzip: update to 1.7.3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dima Panov <fluffy> | ||||
| Component: | Individual Port(s) | Assignee: | Dima Panov <fluffy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | rakuco | ||||
| Priority: | --- | Flags: | rakuco:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
> +-if(NOT CMAKE_SYSTEM_NAME MATCHES Linux)
> +IF(NOT CMAKE_SYSTEM_NAME MATCHES "FreeBSD|Linux")
Can you keep the `if` there in lowercase?
The change itself looks fine to me, but looking at libzip's commit history I can see lots of changes related to the build system, so I'd be more comfortable approving this after an exp-run.
(In reply to Raphael Kubo da Costa from comment #1) Ok, will keep it lowercase as u wish. :) My local partial tree run (most of kde/gnome/xfce/lxde stuff) looks fine with this update. Most changes are bugfixes with no api rewrite, so it should be fine everywhere A commit references this bug: Author: fluffy Date: Wed Jan 6 16:09:15 UTC 2021 New revision: 560536 URL: https://svnweb.freebsd.org/changeset/ports/560536 Log: archivers/libzip: update to 1.7.3 PR: 252456 Submitted by: fluffy Reported by: Repology Approved by: rakuco Changes: head/archivers/libzip/Makefile head/archivers/libzip/distinfo head/archivers/libzip/files/patch-CMakeLists.txt head/archivers/libzip/pkg-plist Committed! In the end it wasn't the build system changes, but as 252483 shows an exp-run would have been useful... |
Created attachment 221311 [details] archivers/libzip: update to 1.7.3