Bug 252470

Summary: databases/luasql-mysql: update to 2.6.0
Product: Ports & Packages Reporter: Marco Beishuizen <mbeis>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
databases/luasql-mysql: update luasql to 2.6.0
mbeis: maintainer-approval+
databases/luasql-mysql: update to 2.6.0 mbeis: maintainer-approval+

Description Marco Beishuizen 2021-01-06 13:21:47 UTC
Created attachment 221324 [details]
databases/luasql-mysql: update luasql to 2.6.0

Update the Luasql ports to 2.6.0
Comment 1 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2021-01-06 18:17:45 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A:  Makefile: [15]: USE_* seen before USES.  According to the porters-handbook, USES must appear first.
 Makefile: PKGNAMEPREFIX appears out-of-order.
 Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY.
 Makefile: "COMMENT" has to appear earlier.
 Makefile: "IGNORE" has to appear earlier.
 Makefile: "USES" has to appear earlier.

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html

Some of the errors will go away one the first line is put in place.

Thanks!
Comment 2 Marco Beishuizen 2021-01-06 19:37:46 UTC
Created attachment 221333 [details]
databases/luasql-mysql: update to 2.6.0

Portlint almost happy... Couldn't get rid of the comment warning.
Comment 3 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2021-01-07 13:22:45 UTC
(In reply to Marco Beishuizen from comment #2)
Don't worry. portlint refers to COMMENT and IGNORE which are conditionals but it lacks the context to know that.

I think the patch is good.

Thanks for the changes!
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-02-13 13:07:13 UTC
A commit references this bug:

Author: amdmi3
Date: Sat Feb 13 13:07:01 UTC 2021
New revision: 565136
URL: https://svnweb.freebsd.org/changeset/ports/565136

Log:
  - Update to 2.6.0

  PR:		252470
  Submitted by:	mbeis@xs4all.nl (maintainer)

Changes:
  head/databases/luasql-mysql/Makefile
  head/databases/luasql-mysql/distinfo