Bug 252493

Comment 1 Mateusz Piotrowski 2021-01-07 16:28:10 UTC

Comment on attachment 221354 [details]
Patch

Thanks for the patch. I just have on question:

>diff --git a/en_US.ISO8859-1/articles/linux-emulation/article.xml b/en_US.ISO8859-1/articles/linux-emulation/article.xml
>index d3e6c8742e..6e94e16e1a 100644
>--- a/en_US.ISO8859-1/articles/linux-emulation/article.xml
>+++ b/en_US.ISO8859-1/articles/linux-emulation/article.xml
>@@ -403,9 +403,7 @@
> 	    different API(es).  The M:N library uses the
> 	    <literal>kse_*</literal> family of syscalls while the 1:1
> 	    library uses the <literal>thr_*</literal> family of
>-	    syscalls.  Because of this, there is no general concept of
>-	    thread ID shared between kernel and userspace.  Of course,
>-	    both threading libraries implement the pthread thread ID
>+	    syscalls.  Due to this, libraries implement the pthread thread ID
> 	    API.  Every kernel thread (as described by <literal>struct
> 	      thread</literal>) has td tid identifier but this is not
> 	    directly accessible from userland and solely serves the

This chunk changes much more than wording. I am not sure if that was your intention. Perhaps we could split the content and wording change into two commits in case that's on purpose.

Oh, that's a mistake.  Sorry!

Created attachment 221358 [details]
Corrected patch

New patch attached.

Comment 4 Mateusz Piotrowski 2021-01-07 20:30:38 UTC

Thanks.

I'll take a closer look now

Not a native speaker, but I haven't seen any actual sentence fragments in the current text. That said, the change reads less repetitive to me and doesn't change the meaning that I could see.

Comment 6 Mateusz Piotrowski 2021-01-08 13:06:53 UTC

Assign to debdrup.

Comment 7 commit-hook 2021-01-08 13:24:06 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=e194334c7994de1d5aa91259075cc4e05d0b4a73

commit e194334c7994de1d5aa91259075cc4e05d0b4a73
Author:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
AuthorDate: 2021-01-08 13:04:42 +0000
Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
CommitDate: 2021-01-08 13:04:42 +0000

    Arch handbook and articles: Reword sentences beginning with 'Because...'

    These sentences can either be or be mistaken for being sentence
    fragments. While it is perfectly reasonable to use subordinate
    conjunctions conversationally, as long as both clauses are explicitly
    used in the same sentence, the handbook or articles are not written
    in this style.

    PR:             252493
    Submitted by:   Ceri Davies (ceri AT submonkey.net)
    Reviewed by:    0mp, pauamma (pauamma AT gundo.com)

 en_US.ISO8859-1/articles/committers-guide/article.xml    |  2 +-
 .../articles/contributors/contrib.develinmemoriam.xml    |  2 +-
 en_US.ISO8859-1/articles/ldap-auth/article.xml           |  2 +-
 en_US.ISO8859-1/articles/linux-emulation/article.xml     |  8 ++++----
 en_US.ISO8859-1/articles/serial-uart/article.xml         | 16 ++++++++--------
 en_US.ISO8859-1/articles/solid-state/article.xml         | 10 +++++-----
 en_US.ISO8859-1/articles/vm-design/article.xml           |  2 +-
 en_US.ISO8859-1/books/arch-handbook/boot/chapter.xml     |  8 ++++----
 .../books/arch-handbook/driverbasics/chapter.xml         |  4 ++--
 en_US.ISO8859-1/books/arch-handbook/isa/chapter.xml      | 10 +++++-----
 en_US.ISO8859-1/books/arch-handbook/pccard/chapter.xml   |  2 +-
 en_US.ISO8859-1/books/arch-handbook/scsi/chapter.xml     |  8 ++++----
 en_US.ISO8859-1/books/arch-handbook/usb/chapter.xml      |  2 +-
 13 files changed, 38 insertions(+), 38 deletions(-)

Comment 8 Mateusz Piotrowski 2021-01-08 13:58:05 UTC

(In reply to Ceri Davies from comment #0)
Thanks for the patch! We would love to review and commit another set of similar changes for books/ :)

(In reply to Mateusz Piotrowski from comment #8)
ok, you're on - 252519