Bug 252507

Summary: Add support for gitup in newvers.sh
Product: Base System Reporter: Michael Osipov <michael.osipov>
Component: binAssignee: Ed Maste <emaste>
Status: Closed FIXED    
Severity: Affects Some People CC: emaste, eugen, michael.osipov
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   

Description Michael Osipov 2021-01-08 10:05:59 UTC
gitup is a minimalist client for shallow Git clones: https://github.com/johnmehr/gitup/. It can substitute svnlite and the fullblown official Git client for most of the users.

Ed Maste offered to review this: https://github.com/johnmehr/gitup/issues/19#issuecomment-753640652

PR: https://github.com/freebsd/freebsd-src/pull/449

Please review and back port to 12-STABLE.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2021-01-14 23:50:46 UTC
I'm currently stuck on https://github.com/johnmehr/gitup/issues/36 for testing
Comment 2 Ed Maste freebsd_committer freebsd_triage 2021-02-08 18:45:47 UTC
https://reviews.freebsd.org/R10:a9fc14fbf445cffd18f34f6a602bdba84bb5a867

Need to MFC still
Comment 3 Michael Osipov 2021-03-14 17:24:06 UTC
Unfortunately, still not in stable/12.
Comment 4 Michael Osipov 2021-05-15 09:18:42 UTC
Ed, can this finally be applied?
Comment 5 Michael Osipov 2021-07-04 08:11:15 UTC
Another friendly reminder. Fix is straight forward.
Comment 6 Michael Osipov 2022-04-13 13:06:58 UTC
Any chance to have this merged?
Comment 7 Eugene Grosbein freebsd_committer freebsd_triage 2022-08-24 12:48:29 UTC
The change is in stable/13 but not in stable/12. Please consider merging this to stable/12, too.
Comment 8 Ed Maste freebsd_committer freebsd_triage 2022-08-24 13:54:24 UTC
It doesn't apply cleanly to stable/12 but I'll take a look at adapting or merging prerequisites next week.
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-09-06 19:32:29 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a3c92efcaa1252bcff87884a76e7c4a9f2c4afc5

commit a3c92efcaa1252bcff87884a76e7c4a9f2c4afc5
Author:     Michael Osipov <michael.osipov@siemens.com>
AuthorDate: 2021-01-05 10:48:39 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-09-06 19:31:39 +0000

    newvers.sh: add support for gitup(1)

    gitup writes a .gituprevision file into the shallow clone directory. Read that
    file and print commit information only.

    Submitted by:   Michael Osipov <michael.osipov@siemens.com>
    Pull Request:   https://github.com/freebsd/freebsd-src/pull/449

    While here, drop the redundant branch name from the git output and don't
    count commits in shallow clones.

    Reported by:    Michael Osipov <michael.osipov@siemens.com>
    MFC after:      2 weeks

    PR:             252507

    (cherry picked from commit a9fc14fbf445cffd18f34f6a602bdba84bb5a867)

 sys/conf/newvers.sh | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)
Comment 10 Michael Osipov 2022-09-06 20:08:33 UTC
Thanks, Ed!