Bug 252532
| Summary: | ifconfig incorrectly displays stp roles | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | jcaplan | ||||
| Component: | kern | Assignee: | Kristof Provost <kp> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | emaste, kp | ||||
| Priority: | --- | ||||||
| Version: | CURRENT | ||||||
| Hardware: | amd64 | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 221504 [details]
proposed patch
https://reviews.freebsd.org/D28425 I'll try to get this in before 13.0. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=88be0e11205e4a2dc77e29f7b4a2e82b8d7c9a5c commit 88be0e11205e4a2dc77e29f7b4a2e82b8d7c9a5c Author: Jonah Caplan <jcaplan@blackberry.com> AuthorDate: 2021-01-30 13:54:09 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2021-02-01 14:27:06 +0000 bridge: fix STP roles and protos strings Add the missing commas that got lost in e5539fb618cc7. PR: 252532 Reviewd by: kp@, donner@, freqlabs@ MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D28425 sys/net/if_bridgevar.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=683d086626cd41a1c22c7ab5cd1c3c52591c5bf7 commit 683d086626cd41a1c22c7ab5cd1c3c52591c5bf7 Author: Jonah Caplan <jcaplan@blackberry.com> AuthorDate: 2021-01-30 13:54:09 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2021-02-04 14:22:45 +0000 bridge: fix STP roles and protos strings Add the missing commas that got lost in e5539fb618cc7. PR: 252532 Reviewd by: kp@, donner@, freqlabs@ MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D28425 (cherry picked from commit 88be0e11205e4a2dc77e29f7b4a2e82b8d7c9a5c) sys/net/if_bridgevar.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=ad60792666831d6beafbc555cc1fec0305d7f8f5 commit ad60792666831d6beafbc555cc1fec0305d7f8f5 Author: Jonah Caplan <jcaplan@blackberry.com> AuthorDate: 2021-01-30 13:54:09 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2021-02-04 08:13:43 +0000 bridge: fix STP roles and protos strings Add the missing commas that got lost in e5539fb618cc7. PR: 252532 Reviewd by: kp@, donner@, freqlabs@ MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D28425 (cherry picked from commit 88be0e11205e4a2dc77e29f7b4a2e82b8d7c9a5c) sys/net/if_bridgevar.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) |
Overview: Steps to Reproduce: 1. create a bridge 2. add a member interface 3. enable stp for the member 4. check member role in ifconfig output Actual Results: # ifconfig bridge0 bridge0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500 ether 58:9c:fc:10:ff:e0 id 02:21:4d:ed:52:0b priority 32768 hellotime 2 fwddelay 15 maxage 20 holdcnt 6 proto stp-rstp maxaddr 2000 timeout 1200 root id 02:21:4d:ed:52:0a priority 32768 ifcost 2000 port 11 member: epair2b flags=1c7<LEARNING,DISCOVER,STP,AUTOEDGE,PTP,AUTOPTP> ifmaxaddr 0 port 11 priority 128 path cost 2000 <unknown proto 2> <unknown role 1> state forwarding Expected Results: # ifconfig bridge0 bridge0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500 ether 58:9c:fc:10:ff:e0 id 02:21:4d:ed:52:0b priority 32768 hellotime 2 fwddelay 15 maxage 20 holdcnt 6 proto stp-rstp maxaddr 2000 timeout 1200 root id 02:21:4d:ed:52:0a priority 32768 ifcost 2000 port 11 member: epair2b flags=1c7<LEARNING,DISCOVER,STP,AUTOEDGE,PTP,AUTOPTP> ifmaxaddr 0 port 11 priority 128 path cost 2000 <unknown proto 2> role root state forwarding Build Date & Hardware: 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r368820: Tue Jan 5 17:30:19 EST 2021